cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH 3/4] gfs2: Issue message when revokes cannot be written
Date: Fri, 21 Apr 2023 15:07:09 -0400	[thread overview]
Message-ID: <20230421190710.397684-4-rpeterso@redhat.com> (raw)
In-Reply-To: <20230421190710.397684-1-rpeterso@redhat.com>

Before this patch, function gfs2_ail_empty_gl would silently return an
error to the caller. This would get silently set into sd_log_error which
would cause a withdraw, but there was no indication why the file system
was withdrawn. This patch adds a fs_err to log the appropriate error
message.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
 fs/gfs2/glops.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index 8e245d793e6b..4b3949f2020b 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -127,6 +127,8 @@ static int gfs2_ail_empty_gl(struct gfs2_glock *gl)
 	if (!ret) {
 		__gfs2_ail_flush(gl, 0, revokes);
 		gfs2_trans_end(sdp);
+	} else {
+		fs_err(sdp, "Transaction error %d: Unable to write revokes.", ret);
 	}
 
 flush:
-- 
2.39.2


  parent reply	other threads:[~2023-04-21 19:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 19:07 [Cluster-devel] [GFS2 PATCH 0/4] Fix revoke processing at unmount and ro Bob Peterson
2023-04-21 19:07 ` [Cluster-devel] [GFS2 PATCH 1/4] gfs2: return errors from gfs2_ail_empty_gl Bob Peterson
2023-04-24 14:07   ` Andreas Gruenbacher
2023-04-21 19:07 ` [Cluster-devel] [GFS2 PATCH 2/4] gfs2: Perform second log flush in gfs2_make_fs_ro Bob Peterson
2023-04-24 14:08   ` Andreas Gruenbacher
2023-04-24 16:08     ` Bob Peterson
2023-04-21 19:07 ` Bob Peterson [this message]
2023-04-21 19:07 ` [Cluster-devel] [GFS2 PATCH 4/4] gfs2: gfs2_ail_empty_gl no log flush on error Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230421190710.397684-4-rpeterso@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).