From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Fri, 21 Apr 2023 15:07:09 -0400 Subject: [Cluster-devel] [GFS2 PATCH 3/4] gfs2: Issue message when revokes cannot be written In-Reply-To: <20230421190710.397684-1-rpeterso@redhat.com> References: <20230421190710.397684-1-rpeterso@redhat.com> Message-ID: <20230421190710.397684-4-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Before this patch, function gfs2_ail_empty_gl would silently return an error to the caller. This would get silently set into sd_log_error which would cause a withdraw, but there was no indication why the file system was withdrawn. This patch adds a fs_err to log the appropriate error message. Signed-off-by: Bob Peterson --- fs/gfs2/glops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 8e245d793e6b..4b3949f2020b 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c @@ -127,6 +127,8 @@ static int gfs2_ail_empty_gl(struct gfs2_glock *gl) if (!ret) { __gfs2_ail_flush(gl, 0, revokes); gfs2_trans_end(sdp); + } else { + fs_err(sdp, "Transaction error %d: Unable to write revokes.", ret); } flush: -- 2.39.2