From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Mon, 24 Apr 2023 14:42:34 +0200 Subject: [Cluster-devel] [PATCH 03/17] fs: rename and move block_page_mkwrite_return In-Reply-To: References: <20230424054926.26927-1-hch@lst.de> <20230424054926.26927-4-hch@lst.de> Message-ID: <20230424124234.GA5786@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Apr 24, 2023 at 01:30:56PM +0100, Matthew Wilcox wrote: > On Mon, Apr 24, 2023 at 07:49:12AM +0200, Christoph Hellwig wrote: > > block_page_mkwrite_return is neither block nor mkwrite specific, and > > should not be under CONFIG_BLOCK. Move it to mm.h and rename it to > > errno_to_vmfault. > > Could you move it about 300 lines down and put it near vmf_error() > so we think about how to unify the two at some point? > > Perhaps it should better be called vmf_fs_error() for now since the > errnos it handles are the kind generated by filesystems. I'll look into unifying them for the next version.