From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 05/12] fs: dlm: don't check othercon twice
Date: Mon, 29 May 2023 17:44:33 -0400 [thread overview]
Message-ID: <20230529214440.2542721-5-aahringo@redhat.com> (raw)
In-Reply-To: <20230529214440.2542721-1-aahringo@redhat.com>
This patch removes an another check if con->othercon set inside the
branch which already does that.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
fs/dlm/lowcomms.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 5aad4d4842eb..b28505b8b23b 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1497,8 +1497,7 @@ int dlm_lowcomms_close(int nodeid)
call_srcu(&connections_srcu, &con->rcu, connection_release);
if (con->othercon) {
clean_one_writequeue(con->othercon);
- if (con->othercon)
- call_srcu(&connections_srcu, &con->othercon->rcu, connection_release);
+ call_srcu(&connections_srcu, &con->othercon->rcu, connection_release);
}
srcu_read_unlock(&connections_srcu, idx);
--
2.31.1
next prev parent reply other threads:[~2023-05-29 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 21:44 [Cluster-devel] [PATCH dlm/next 01/12] fs: dlm: revert check required context while close Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 02/12] fs: dlm: clear pending bit when queue was empty Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 03/12] fs: dlm: fix missing pending to false Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 04/12] fs: dlm: unregister memory at the very last Alexander Aring
2023-05-29 21:44 ` Alexander Aring [this message]
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 06/12] fs: dlm: cleanup STOP_IO bitflag set when stop io Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 07/12] fs: dlm: move dlm_purge_lkb_callbacks to user module Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 08/12] fs: dlm: warn about messages from left nodes Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 09/12] fs: dlm: filter ourself midcomms calls Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 10/12] fs: dlm: handle lkb wait count as atomic_t Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 11/12] fs: dlm: handle sequence numbers as atomic Alexander Aring
2023-05-29 21:44 ` [Cluster-devel] [PATCH dlm/next 12/12] fs: dlm: add send ack threshold and append acks to msgs Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529214440.2542721-5-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).