From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Date: Mon, 29 May 2023 17:44:33 -0400 Subject: [Cluster-devel] [PATCH dlm/next 05/12] fs: dlm: don't check othercon twice In-Reply-To: <20230529214440.2542721-1-aahringo@redhat.com> References: <20230529214440.2542721-1-aahringo@redhat.com> Message-ID: <20230529214440.2542721-5-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This patch removes an another check if con->othercon set inside the branch which already does that. Signed-off-by: Alexander Aring --- fs/dlm/lowcomms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 5aad4d4842eb..b28505b8b23b 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1497,8 +1497,7 @@ int dlm_lowcomms_close(int nodeid) call_srcu(&connections_srcu, &con->rcu, connection_release); if (con->othercon) { clean_one_writequeue(con->othercon); - if (con->othercon) - call_srcu(&connections_srcu, &con->othercon->rcu, connection_release); + call_srcu(&connections_srcu, &con->othercon->rcu, connection_release); } srcu_read_unlock(&connections_srcu, idx); -- 2.31.1