From: Matthew Wilcox (Oracle) <willy@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 05/14] gfs2: Support ludicrously large folios in gfs2_trans_add_databufs()
Date: Tue, 6 Jun 2023 23:33:37 +0100 [thread overview]
Message-ID: <20230606223346.3241328-6-willy@infradead.org> (raw)
In-Reply-To: <20230606223346.3241328-1-willy@infradead.org>
We may someday support folios larger than 4GB, so use a size_t for
the byte count within a folio to prevent unpleasant truncations.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Tested-by: Bob Peterson <rpeterso@redhat.com>
Reviewed-by: Bob Peterson <rpeterso@redhat.com>
---
fs/gfs2/aops.c | 6 +++---
fs/gfs2/aops.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 3a2be1901e1e..1c407eba1e30 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -38,13 +38,13 @@
void gfs2_trans_add_databufs(struct gfs2_inode *ip, struct folio *folio,
- unsigned int from, unsigned int len)
+ size_t from, size_t len)
{
struct buffer_head *head = folio_buffers(folio);
unsigned int bsize = head->b_size;
struct buffer_head *bh;
- unsigned int to = from + len;
- unsigned int start, end;
+ size_t to = from + len;
+ size_t start, end;
for (bh = head, start = 0; bh != head || !start;
bh = bh->b_this_page, start = end) {
diff --git a/fs/gfs2/aops.h b/fs/gfs2/aops.h
index 09db1914425e..f08322ef41cf 100644
--- a/fs/gfs2/aops.h
+++ b/fs/gfs2/aops.h
@@ -10,6 +10,6 @@
extern void adjust_fs_space(struct inode *inode);
extern void gfs2_trans_add_databufs(struct gfs2_inode *ip, struct folio *folio,
- unsigned int from, unsigned int len);
+ size_t from, size_t len);
#endif /* __AOPS_DOT_H__ */
--
2.39.2
next prev parent reply other threads:[~2023-06-06 22:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 22:33 [Cluster-devel] [PATCH v2 00/14] gfs2/buffer folio changes for 6.5 Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 01/14] gfs2: Use a folio inside gfs2_jdata_writepage() Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 02/14] gfs2: Pass a folio to __gfs2_jdata_write_folio() Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 03/14] gfs2: Convert gfs2_write_jdata_page() to gfs2_write_jdata_folio() Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 04/14] buffer: Convert __block_write_full_page() to __block_write_full_folio() Matthew Wilcox
2023-06-06 22:33 ` Matthew Wilcox [this message]
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 06/14] buffer: Make block_write_full_page() handle large folios correctly Matthew Wilcox
2023-06-06 23:15 ` Andreas Grünbacher
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 07/14] buffer: Convert block_page_mkwrite() to use a folio Matthew Wilcox
2023-06-06 23:26 ` Andreas Grünbacher
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 08/14] buffer: Convert __block_commit_write() to take " Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 09/14] buffer; Convert page_zero_new_buffers() to folio_zero_new_buffers() Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 10/14] buffer: Convert grow_dev_page() to use a folio Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 11/14] buffer: Convert init_page_buffers() to folio_init_buffers() Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 12/14] buffer: Convert link_dev_buffers to take a folio Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 13/14] buffer: Use a folio in __find_get_block_slow() Matthew Wilcox
2023-06-06 22:33 ` [Cluster-devel] [PATCH v2 14/14] buffer: Convert block_truncate_page() to use a folio Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606223346.3241328-6-willy@infradead.org \
--to=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).