From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Wed, 7 Jun 2023 09:35:52 +0200 Subject: [Cluster-devel] [PATCH dlm/next] fs: dlm: fix nfs async lock callback handling In-Reply-To: <20230606215626.327239-1-aahringo@redhat.com> References: <20230606215626.327239-1-aahringo@redhat.com> Message-ID: <2023060744-raft-gizzard-ad1d@gregkh> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jun 06, 2023 at 05:56:26PM -0400, Alexander Aring wrote: > This patch is fixing the current the callback handling if it's a nfs > async lock request signaled if fl_lmops is set. > > When using `stress-ng --fcntl 32` on the kernel log there are several > messages like: > > [11185.123533] dlm: dlm_plock_callback: vfs lock error 5d5127 file 000000002dd10f4d fl 000000007d13afae > [11185.127135] dlm: dlm_plock_callback: vfs lock error 5d5127 file 000000002dd10f4d fl 00000000a6046fa0 > [11185.142668] dlm: dlm_plock_callback: vfs lock error 5d5127 file 000000002dd10f4d fl 000000001d13dfa5 > > The commit 40595cdc93ed ("nfs: block notification on fs with its > own ->lock") using only trylocks in an asynchronous polling behaviour. The > behaviour before was however differently by evaluating F_SETLKW or F_SETLK > and evaluating FL_SLEEP which was the case before commit 40595cdc93ed > ("nfs: block notification on fs with its own ->lock"). This behaviour > seems to be broken before. This patch will fix the behaviour for the > special nfs case before commit 40595cdc93ed ("nfs: block notification on > fs with its own ->lock"). > > There is still a TODO of solving the case when an nfs locking request > got interrupted. > > Fixes: 40595cdc93ed ("nfs: block notification on fs with its own ->lock") > Signed-off-by: Alexander Aring > --- > fs/dlm/plock.c | 22 +--------------------- > 1 file changed, 1 insertion(+), 21 deletions(-) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.