cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v5 3/8] tmpfs: bump the mtime/ctime/iversion when page becomes writeable
Date: Thu, 13 Jul 2023 19:00:52 -0400	[thread overview]
Message-ID: <20230713-mgctime-v5-3-9eb795d2ae37@kernel.org> (raw)
In-Reply-To: <20230713-mgctime-v5-0-9eb795d2ae37@kernel.org>

Most filesystems that use the pagecache will update the mtime, ctime,
and change attribute when a page becomes writeable. Add a page_mkwrite
operation for tmpfs and just use it to bump the mtime, ctime and change
attribute.

This fixes xfstest generic/080 on tmpfs.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 mm/shmem.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/mm/shmem.c b/mm/shmem.c
index b154af49d2df..654d9a585820 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2169,6 +2169,16 @@ static vm_fault_t shmem_fault(struct vm_fault *vmf)
 	return ret;
 }
 
+static vm_fault_t shmem_page_mkwrite(struct vm_fault *vmf)
+{
+	struct vm_area_struct *vma = vmf->vma;
+	struct inode *inode = file_inode(vma->vm_file);
+
+	file_update_time(vma->vm_file);
+	inode_inc_iversion(inode);
+	return 0;
+}
+
 unsigned long shmem_get_unmapped_area(struct file *file,
 				      unsigned long uaddr, unsigned long len,
 				      unsigned long pgoff, unsigned long flags)
@@ -4210,6 +4220,7 @@ static const struct super_operations shmem_ops = {
 
 static const struct vm_operations_struct shmem_vm_ops = {
 	.fault		= shmem_fault,
+	.page_mkwrite	= shmem_page_mkwrite,
 	.map_pages	= filemap_map_pages,
 #ifdef CONFIG_NUMA
 	.set_policy     = shmem_set_policy,
@@ -4219,6 +4230,7 @@ static const struct vm_operations_struct shmem_vm_ops = {
 
 static const struct vm_operations_struct shmem_anon_vm_ops = {
 	.fault		= shmem_fault,
+	.page_mkwrite	= shmem_page_mkwrite,
 	.map_pages	= filemap_map_pages,
 #ifdef CONFIG_NUMA
 	.set_policy     = shmem_set_policy,

-- 
2.41.0


  parent reply	other threads:[~2023-07-13 23:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 23:00 [Cluster-devel] [PATCH v5 0/8] fs: implement multigrain timestamps Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 1/8] fs: pass the request_mask to generic_fillattr Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 2/8] fs: add infrastructure for multigrain timestamps Jeff Layton
2023-07-13 23:00 ` Jeff Layton [this message]
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 4/8] tmpfs: add support " Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 5/8] xfs: XFS_ICHGTIME_CREATE is unused Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 6/8] xfs: switch to multigrain timestamps Jeff Layton
2023-07-19  1:35   ` Dave Chinner
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 7/8] ext4: " Jeff Layton
2023-07-13 23:00 ` [Cluster-devel] [PATCH v5 8/8] btrfs: convert " Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230713-mgctime-v5-3-9eb795d2ae37@kernel.org \
    --to=jlayton@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).