From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCHv3 v6.5-rc2 0/3] fs: dlm: lock cancellation feature
Date: Tue, 18 Jul 2023 14:07:18 -0400 [thread overview]
Message-ID: <20230718180721.745569-1-aahringo@redhat.com> (raw)
Hi,
this patch series implements lock cancellation feature. Either if a
POSIX F_SETLKW got interrupted by a signal (most common use case) or
lockd sends a F_CANCELLK request.
As I note: the current nfs handling seems to be broken. This patch
assumes that the current behaviour works. Future patches will fix the
nfs handling which seems to be broken anyway.
- Alex
changes since v3:
- drop patch "fs: dlm: ignore DLM_PLOCK_FL_CLOSE flag results", we assume
that plock ops with DLM_PLOCK_FL_CLOSE flag set will never fail.
- Let DLM_PLOCK_OP_CANCEL to always send a reply back. This is useful when
the op fails, e.g. older dlm_controld will return -EINVAL and we can
implement F_CANCELLK which does not have a reference of the plock_op
instance.
- remove DLM_PLOCK_OP_FLAG_SENT as it was only a optimization for a
rare case. That DLM_PLOCK_OP_CANCEL sends a reply back will
synchronize it now.
- remove DLM_PLOCK_OP_FLAG_INTERRUPTED as it's not necessary anymore
because waiting for a reply of DLM_PLOCK_OP_CANCEL we don't need to
handle this special case anymore.
- add "fs: dlm: remove twice newline" because I saw this while doing nfs
lockd experiments.
Alexander Aring (3):
fs: dlm: remove twice newline
fs: dlm: allow to F_SETLKW getting interrupted
fs: dlm: fix F_CANCELLK to cancel pending request
fs/dlm/plock.c | 162 ++++++++++++++++++++++++++-------
fs/gfs2/file.c | 9 +-
fs/ocfs2/stack_user.c | 13 +--
include/linux/dlm_plock.h | 2 +
include/uapi/linux/dlm_plock.h | 1 +
5 files changed, 136 insertions(+), 51 deletions(-)
--
2.31.1
next reply other threads:[~2023-07-18 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 18:07 Alexander Aring [this message]
2023-07-18 18:07 ` [Cluster-devel] [PATCHv3 v6.5-rc2 1/3] fs: dlm: remove twice newline Alexander Aring
2023-07-18 18:07 ` [Cluster-devel] [PATCHv3 v6.5-rc2 2/3] fs: dlm: allow to F_SETLKW getting interrupted Alexander Aring
2023-07-18 18:07 ` [Cluster-devel] [PATCHv3 v6.5-rc2 3/3] fs: dlm: fix F_CANCELLK to cancel pending request Alexander Aring
2023-07-19 18:33 ` Alexander Aring
2023-07-25 14:26 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718180721.745569-1-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).