From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Date: Tue, 18 Jul 2023 14:07:18 -0400 Subject: [Cluster-devel] [PATCHv3 v6.5-rc2 0/3] fs: dlm: lock cancellation feature Message-ID: <20230718180721.745569-1-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, this patch series implements lock cancellation feature. Either if a POSIX F_SETLKW got interrupted by a signal (most common use case) or lockd sends a F_CANCELLK request. As I note: the current nfs handling seems to be broken. This patch assumes that the current behaviour works. Future patches will fix the nfs handling which seems to be broken anyway. - Alex changes since v3: - drop patch "fs: dlm: ignore DLM_PLOCK_FL_CLOSE flag results", we assume that plock ops with DLM_PLOCK_FL_CLOSE flag set will never fail. - Let DLM_PLOCK_OP_CANCEL to always send a reply back. This is useful when the op fails, e.g. older dlm_controld will return -EINVAL and we can implement F_CANCELLK which does not have a reference of the plock_op instance. - remove DLM_PLOCK_OP_FLAG_SENT as it was only a optimization for a rare case. That DLM_PLOCK_OP_CANCEL sends a reply back will synchronize it now. - remove DLM_PLOCK_OP_FLAG_INTERRUPTED as it's not necessary anymore because waiting for a reply of DLM_PLOCK_OP_CANCEL we don't need to handle this special case anymore. - add "fs: dlm: remove twice newline" because I saw this while doing nfs lockd experiments. Alexander Aring (3): fs: dlm: remove twice newline fs: dlm: allow to F_SETLKW getting interrupted fs: dlm: fix F_CANCELLK to cancel pending request fs/dlm/plock.c | 162 ++++++++++++++++++++++++++------- fs/gfs2/file.c | 9 +- fs/ocfs2/stack_user.c | 13 +-- include/linux/dlm_plock.h | 2 + include/uapi/linux/dlm_plock.h | 1 + 5 files changed, 136 insertions(+), 51 deletions(-) -- 2.31.1