From: Jeff Layton <jlayton@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v6 3/7] tmpfs: bump the mtime/ctime/iversion when page becomes writeable
Date: Tue, 25 Jul 2023 10:58:16 -0400 [thread overview]
Message-ID: <20230725-mgctime-v6-3-a794c2b7abca@kernel.org> (raw)
In-Reply-To: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org>
Most filesystems that use the pagecache will update the mtime, ctime,
and change attribute when a page becomes writeable. Add a page_mkwrite
operation for tmpfs and just use it to bump the mtime, ctime and change
attribute.
This fixes xfstest generic/080 on tmpfs.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
mm/shmem.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/mm/shmem.c b/mm/shmem.c
index b154af49d2df..654d9a585820 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2169,6 +2169,16 @@ static vm_fault_t shmem_fault(struct vm_fault *vmf)
return ret;
}
+static vm_fault_t shmem_page_mkwrite(struct vm_fault *vmf)
+{
+ struct vm_area_struct *vma = vmf->vma;
+ struct inode *inode = file_inode(vma->vm_file);
+
+ file_update_time(vma->vm_file);
+ inode_inc_iversion(inode);
+ return 0;
+}
+
unsigned long shmem_get_unmapped_area(struct file *file,
unsigned long uaddr, unsigned long len,
unsigned long pgoff, unsigned long flags)
@@ -4210,6 +4220,7 @@ static const struct super_operations shmem_ops = {
static const struct vm_operations_struct shmem_vm_ops = {
.fault = shmem_fault,
+ .page_mkwrite = shmem_page_mkwrite,
.map_pages = filemap_map_pages,
#ifdef CONFIG_NUMA
.set_policy = shmem_set_policy,
@@ -4219,6 +4230,7 @@ static const struct vm_operations_struct shmem_vm_ops = {
static const struct vm_operations_struct shmem_anon_vm_ops = {
.fault = shmem_fault,
+ .page_mkwrite = shmem_page_mkwrite,
.map_pages = filemap_map_pages,
#ifdef CONFIG_NUMA
.set_policy = shmem_set_policy,
--
2.41.0
next prev parent reply other threads:[~2023-07-25 14:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 14:58 [Cluster-devel] [PATCH v6 0/7] fs: implement multigrain timestamps Jeff Layton
2023-07-25 14:58 ` [Cluster-devel] [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr Jeff Layton
2023-07-26 2:46 ` Xiubo Li
2023-07-26 9:40 ` Joseph Qi
2023-07-26 10:49 ` Jeff Layton
2023-08-02 17:43 ` Jan Kara
2023-08-02 18:47 ` Paulo Alcantara
2023-08-29 22:44 ` Al Viro
2023-08-29 22:58 ` Jeff Layton
2023-08-30 0:02 ` Al Viro
2023-08-30 0:43 ` Jeff Layton
2023-08-30 1:22 ` Al Viro
2023-07-25 14:58 ` [Cluster-devel] [PATCH v6 2/7] fs: add infrastructure for multigrain timestamps Jeff Layton
2023-08-02 19:35 ` Jan Kara
2023-08-02 20:54 ` Jeff Layton
2023-08-03 7:07 ` Christian Brauner
2023-07-25 14:58 ` Jeff Layton [this message]
2023-07-26 1:39 ` [Cluster-devel] [PATCH v6 3/7] tmpfs: bump the mtime/ctime/iversion when page becomes writeable Hugh Dickins
2023-07-26 10:26 ` Jeff Layton
2023-07-25 14:58 ` [Cluster-devel] [PATCH v6 4/7] tmpfs: add support for multigrain timestamps Jeff Layton
2023-08-02 19:37 ` Jan Kara
2023-07-25 14:58 ` [Cluster-devel] [PATCH v6 5/7] xfs: switch to " Jeff Layton
2023-08-02 17:48 ` Darrick J. Wong
2023-08-02 18:21 ` Jeff Layton
2023-08-03 7:05 ` Christian Brauner
2023-07-25 14:58 ` [Cluster-devel] [PATCH v6 6/7] ext4: " Jeff Layton
2023-08-02 19:38 ` Jan Kara
2023-07-25 14:58 ` [Cluster-devel] [PATCH v6 7/7] btrfs: convert " Jeff Layton
2023-07-26 12:44 ` David Sterba
2023-07-28 11:00 ` [Cluster-devel] (subset) [PATCH v6 0/7] fs: implement " Christian Brauner
2023-07-28 11:00 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725-mgctime-v6-3-a794c2b7abca@kernel.org \
--to=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).