From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 921FBC27C40 for ; Thu, 24 Aug 2023 21:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692911471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4kmIPl82QlFlfdEPTZ6/KOVcZ1th9lFZlK8b4+z36x8=; b=d/yfbO6W07hQLNVxskJFciVc5xnQhfgoX09Mde6Nw/uJk5TKsww7kDAbtadxseLuRdRP2y JfnOj8mHG8x4R30VsxwZy0k4cE9YROkb4OEalda4HuCh+sK6OGIRDyQUpkQGJDaZR3VS16 AoPMUC/BecVcSpVa9kkt5ffMX+7u2rQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-571-6JEMoqEsOxSiz-UDgR1WXQ-1; Thu, 24 Aug 2023 17:11:07 -0400 X-MC-Unique: 6JEMoqEsOxSiz-UDgR1WXQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD4E5101A528; Thu, 24 Aug 2023 21:11:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4611492C18; Thu, 24 Aug 2023 21:11:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7389F19465B2; Thu, 24 Aug 2023 21:11:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1F4701946589 for ; Thu, 24 Aug 2023 21:11:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0A6F7492C3A; Thu, 24 Aug 2023 21:11:05 +0000 (UTC) Received: from pasta.redhat.com (unknown [10.45.224.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 810C9492C14; Thu, 24 Aug 2023 21:11:04 +0000 (UTC) From: Andreas Gruenbacher To: cluster-devel@redhat.com Date: Thu, 24 Aug 2023 23:11:00 +0200 Message-Id: <20230824211101.3242346-4-agruenba@redhat.com> In-Reply-To: <20230824211101.3242346-1-agruenba@redhat.com> References: <20230824211101.3242346-1-agruenba@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Subject: [Cluster-devel] [PATCH 3/4] gfs2: Fix logd wakeup on I/O error X-BeenThere: cluster-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: "\[Cluster devel\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cluster-devel-bounces@redhat.com Sender: "Cluster-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true When quotad detects an I/O error, it sets sd_log_error and then it wakes up logd to withdraw the filesystem. However, logd doesn't wake up when sd_log_error is set. Fix that. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/log.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index aaca22f2aa2d..abe4397dc59b 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -1340,6 +1340,7 @@ int gfs2_logd(void *data) test_bit(SDF_FORCE_AIL_FLUSH, &sdp->sd_flags) || gfs2_ail_flush_reqd(sdp) || gfs2_jrnl_flush_reqd(sdp) || + sdp->sd_log_error || kthread_should_stop(), t); } -- 2.40.1