From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1808C83F2E for ; Tue, 29 Aug 2023 08:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693298478; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SuwxFwaiezuBRSHTJxYRoDnfFAjXOyv9oGVZK6cOgLs=; b=KSSlvaYtfP3ZlB3fe4q3ygUfw2uZDBYE5Y+nbQaVDQE7gAO2UpiB7lw+1Rp2Bmvo3l4HoJ /E73CevSyv2UFW/DmhUjPHIo0a3+qYnnFMc3HmBsvqYnnyr8neXUERaoAYUcaw9KjdvY+C nIOkJCT6h9IcVh5ZayYhGs6vzsvH+2g= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-vwtDmT6_Oe2qVCiLfQWb5g-1; Tue, 29 Aug 2023 04:41:12 -0400 X-MC-Unique: vwtDmT6_Oe2qVCiLfQWb5g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2C1833C0FCA3; Tue, 29 Aug 2023 08:41:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BDB41121318; Tue, 29 Aug 2023 08:41:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4A47E1946A50; Tue, 29 Aug 2023 08:41:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0F9AF19465A8 for ; Fri, 25 Aug 2023 14:00:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E0B562166B26; Fri, 25 Aug 2023 14:00:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D92212166B27 for ; Fri, 25 Aug 2023 14:00:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-inbound-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCCE7800C7F for ; Fri, 25 Aug 2023 14:00:44 +0000 (UTC) Received: from out-246.mta1.migadu.com (out-246.mta1.migadu.com [95.215.58.246]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-xl8mK5gxNHqElfCyNbrcFQ-1; Fri, 25 Aug 2023 10:00:40 -0400 X-MC-Unique: xl8mK5gxNHqElfCyNbrcFQ-1 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Hao Xu To: io-uring@vger.kernel.org, Jens Axboe Date: Fri, 25 Aug 2023 21:54:14 +0800 Message-Id: <20230825135431.1317785-13-hao.xu@linux.dev> In-Reply-To: <20230825135431.1317785-1-hao.xu@linux.dev> References: <20230825135431.1317785-1-hao.xu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mailman-Approved-At: Tue, 29 Aug 2023 08:41:07 +0000 Subject: [Cluster-devel] [PATCH 12/29] xfs: enforce GFP_NOIO implicitly during nowait time update X-BeenThere: cluster-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: "\[Cluster devel\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , "Darrick J . Wong" , Dominique Martinet , Dave Chinner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Stefan Roesch , Clay Harris , linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, codalist@coda.cs.cmu.edu, cluster-devel@redhat.com, linux-cachefs@redhat.com, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-block@vger.kernel.org, Alexander Viro , Christian Brauner , netdev@vger.kernel.org, samba-technical@lists.samba.org, linux-unionfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, bpf@vger.kernel.org, Pavel Begunkov , linux-btrfs@vger.kernel.org Errors-To: cluster-devel-bounces@redhat.com Sender: "Cluster-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: linux.dev Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="US-ASCII"; x-default=true From: Hao Xu Enforce GFP_NOIO logic implicitly by set pflags if we are in nowait time update process. Nowait semantics means no waiting for IO, therefore GFP_NOIO is needed. Signed-off-by: Hao Xu --- fs/xfs/xfs_iops.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index bf1d4c31f009..5fa391083de9 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -1037,6 +1037,8 @@ xfs_vn_update_time( =09int=09=09=09log_flags =3D XFS_ILOG_TIMESTAMP; =09struct xfs_trans=09*tp; =09int=09=09=09error; +=09int=09=09=09old_pflags; +=09bool=09=09=09nowait =3D flags & S_NOWAIT; =20 =09trace_xfs_update_time(ip); =20 @@ -1049,13 +1051,18 @@ xfs_vn_update_time( =09=09log_flags |=3D XFS_ILOG_CORE; =09} =20 +=09if (nowait) +=09=09old_pflags =3D memalloc_noio_save(); + =09error =3D xfs_trans_alloc(mp, &M_RES(mp)->tr_fsyncts, 0, 0, 0, &tp); =09if (error) -=09=09return error; +=09=09goto out; =20 -=09if (flags & S_NOWAIT) { -=09=09if (!xfs_ilock_nowait(ip, XFS_ILOCK_EXCL)) -=09=09=09return -EAGAIN; +=09if (nowait) { +=09=09if (!xfs_ilock_nowait(ip, XFS_ILOCK_EXCL)) { +=09=09=09error =3D -EAGAIN; +=09=09=09goto out; +=09=09} =09} else { =09=09xfs_ilock(ip, XFS_ILOCK_EXCL); =09} @@ -1069,7 +1076,12 @@ xfs_vn_update_time( =20 =09xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL); =09xfs_trans_log_inode(tp, ip, log_flags); -=09return xfs_trans_commit(tp); +=09error =3D xfs_trans_commit(tp); + +out: +=09if (nowait) +=09=09memalloc_noio_restore(old_pflags); +=09return error; } =20 STATIC int --=20 2.25.1