From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A8B6CE79DE for ; Wed, 20 Sep 2023 15:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695222255; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=pv/mshlnOGkJ5ebR+d6AqRiPt7G4UklH+5Y/YwatjVw=; b=Ar8oVEueBo2SeNxz+y19hxzReW66+t6fh0xFqGrggal+uFb3oWzuvUMHZv/UcHUyCpIQln FFMPkFqhtbZYg/pbzvUO4pCJWuCsGt3CGIkmmP2xL6HGqlC3UthdTcXNfIme0yifIh2stm u8OVelSam4Yj7k/Uf6IBuy32Xl1j2y8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-312-DlGOc9-gO_G9BG_3ar6Osw-1; Wed, 20 Sep 2023 11:04:12 -0400 X-MC-Unique: DlGOc9-gO_G9BG_3ar6Osw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E404438116FE; Wed, 20 Sep 2023 15:04:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8724720268CB; Wed, 20 Sep 2023 15:04:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3540F1946594; Wed, 20 Sep 2023 15:04:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4DDED194658D for ; Wed, 20 Sep 2023 14:54:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 18B3B1005E27; Wed, 20 Sep 2023 14:53:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10FAA1004145 for ; Wed, 20 Sep 2023 14:53:52 +0000 (UTC) Received: from us-smtp-inbound-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E66BD1E441DA for ; Wed, 20 Sep 2023 14:53:51 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-HRXtSBNLOsOY-3vZSNiFGQ-1; Wed, 20 Sep 2023 10:53:48 -0400 X-MC-Unique: HRXtSBNLOsOY-3vZSNiFGQ-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F51AB81DCF; Wed, 20 Sep 2023 14:53:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B10CFC433C7; Wed, 20 Sep 2023 14:53:28 +0000 (UTC) Date: Wed, 20 Sep 2023 16:53:26 +0200 From: Christian Brauner To: Chuck Lever III , Jeff Layton , Jan Kara Message-ID: <20230920-keine-eile-c9755b5825db@brauner> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230919110457.7fnmzo4nqsi43yqq@quack3> <1f29102c09c60661758c5376018eac43f774c462.camel@kernel.org> <4511209.uG2h0Jr0uP@nimes> <08b5c6fd3b08b87fa564bb562d89381dd4e05b6a.camel@kernel.org> <20230920-leerung-krokodil-52ec6cb44707@brauner> <20230920101731.ym6pahcvkl57guto@quack3> <317d84b1b909b6c6519a2406fcb302ce22dafa41.camel@kernel.org> <20230920-raser-teehaus-029cafd5a6e4@brauner> <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> MIME-Version: 1.0 In-Reply-To: <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Subject: Re: [Cluster-devel] [PATCH v7 12/13] ext4: switch to multigrain timestamps X-BeenThere: cluster-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: "\[Cluster devel\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Martin Brandenburg , Konstantin Komarov , "linux-xfs@vger.kernel.org" , "Darrick J. Wong" , Dominique Martinet , Christian Schoenebeck , "linux-unionfs@vger.kernel.org" , David Howells , Chris Mason , Andreas Dilger , Hans de Goede , Marc Dionne , "codalist@coda.cs.cmu.edu" , "linux-afs@lists.infradead.org" , "linux-mtd@lists.infradead.org" , Mike Marshall , Paulo Alcantara , Amir Goldstein , Eric Van Hensbergen , "bug-gnulib@gnu.org" , Miklos Szeredi , Richard Weinberger , Mark Fasheh , Hugh Dickins , Tyler Hicks , "cluster-devel@redhat.com" , "coda@cs.cmu.edu" , "linux-mm@kvack.org" , Gao Xiang , Iurii Zaikin , Namjae Jeon , Trond Myklebust , Xi Ruoyao , Shyam Prasad N , "ecryptfs@vger.kernel.org" , Kees Cook , "ocfs2-devel@lists.linux.dev" , "linux-cifs@vger.kernel.org" , Chao Yu , "linux-erofs@lists.ozlabs.org" , Josef Bacik , Tom Talpey , Tejun Heo , Yue Hu , Al Viro , Ronnie Sahlberg , David Sterba , Jaegeuk Kim , "ceph-devel@vger.kernel.org" , Xiubo Li , Ilya Dryomov , OGAWA Hirofumi , Jan Harkes , Linux NFS Mailing List , "linux-ext4@vger.kernel.org" , Theodore Ts'o , Joseph Qi , Greg Kroah-Hartman , "v9fs@lists.linux.dev" , "ntfs3@lists.linux.dev" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Steve French , Sergey Senozhatsky , Luis Chamberlain , Jeffle Xu , "devel@lists.orangefs.org" , Anna Schumaker , Jan Kara , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Sungjong Seo , Bruno Haible , "linux-btrfs@vger.kernel.org" , Joel Becker Errors-To: cluster-devel-bounces@redhat.com Sender: "Cluster-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kernel.org Content-Type: text/plain; charset=utf-8 Content-Disposition: inline > You could put it behind an EXPERIMENTAL Kconfig option so that the > code stays in and can be used by the brave or foolish while it is > still being refined. Given that the discussion has now fully gone back to the drawing board and this is a regression the honest thing to do is to revert the five patches that introduce the infrastructure: ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") d48c33972916 ("tmpfs: add support for multigrain timestamps") e44df2664746 ("xfs: switch to multigrain timestamps") 0269b585868e ("ext4: switch to multigrain timestamps") 50e9ceef1d4f ("btrfs: convert to multigrain timestamps") The conversion to helpers and cleanups are sane and should stay and can be used for any solution that gets built on top of it. I'd appreciate a look at the branch here: git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.ctime.revert survives xfstests.