From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH 0/2] Fix regression in "Ignore journal log writes for jdata holes"
Date: Thu, 12 Nov 2020 10:44:55 -0500 (EST) [thread overview]
Message-ID: <2023985976.25677509.1605195895739.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20201112145743.376789-1-rpeterso@redhat.com>
----- Original Message -----
> Patch b2a846dbef4e ("gfs2: Ignore journal log writes for jdata holes"
> caused a regression. It fixed one specific problem while breaking others.
> The problem was that it changed the behavior of function gfs2_block_map
> which is used by multiple callers so it had unintended consequences for
> other callers.
>
> This patch set reverts the patch and replaces it with a more targeted
> solution that fixes just the one case it needs to.
>
> Bob Peterson (2):
> Revert "gfs2: Ignore journal log writes for jdata holes"
> gfs2: Make special version of gfs2_get_block_noalloc for jdata
>
> fs/gfs2/aops.c | 30 ++++++++++++++++++++++++++++--
> fs/gfs2/bmap.c | 8 ++------
> fs/gfs2/log.c | 2 ++
> 3 files changed, 32 insertions(+), 8 deletions(-)
>
> --
> 2.26.2
NACK. Ignore this for now. Something's wrong and I'm investigating.
Regards,
Bob Peterson
next prev parent reply other threads:[~2020-11-12 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 14:57 [Cluster-devel] [GFS2 PATCH 0/2] Fix regression in "Ignore journal log writes for jdata holes" Bob Peterson
2020-11-12 14:57 ` [Cluster-devel] [GFS2 PATCH 1/2] Revert "gfs2: Ignore " Bob Peterson
2020-11-12 14:57 ` [Cluster-devel] [GFS2 PATCH 2/2] gfs2: Make special version of gfs2_get_block_noalloc for jdata Bob Peterson
2020-11-12 15:44 ` Bob Peterson [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-12 14:54 [Cluster-devel] [GFS2 PATCH 0/2] Fix regression in "Ignore journal log writes for jdata holes" Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023985976.25677509.1605195895739.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).