From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 12 Nov 2020 10:44:55 -0500 (EST) Subject: [Cluster-devel] [GFS2 PATCH 0/2] Fix regression in "Ignore journal log writes for jdata holes" In-Reply-To: <20201112145743.376789-1-rpeterso@redhat.com> References: <20201112145743.376789-1-rpeterso@redhat.com> Message-ID: <2023985976.25677509.1605195895739.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > Patch b2a846dbef4e ("gfs2: Ignore journal log writes for jdata holes" > caused a regression. It fixed one specific problem while breaking others. > The problem was that it changed the behavior of function gfs2_block_map > which is used by multiple callers so it had unintended consequences for > other callers. > > This patch set reverts the patch and replaces it with a more targeted > solution that fixes just the one case it needs to. > > Bob Peterson (2): > Revert "gfs2: Ignore journal log writes for jdata holes" > gfs2: Make special version of gfs2_get_block_noalloc for jdata > > fs/gfs2/aops.c | 30 ++++++++++++++++++++++++++++-- > fs/gfs2/bmap.c | 8 ++------ > fs/gfs2/log.c | 2 ++ > 3 files changed, 32 insertions(+), 8 deletions(-) > > -- > 2.26.2 NACK. Ignore this for now. Something's wrong and I'm investigating. Regards, Bob Peterson