cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: forcibly flush ail to relieve memory	pressure
Date: Fri, 4 Aug 2017 13:21:44 -0400 (EDT)	[thread overview]
Message-ID: <2033509119.38883626.1501867304650.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1501864822-32906-1-git-send-email-adas@redhat.com>

----- Original Message -----
| On systems with low memory, it is possible for gfs2 to infinitely
| loop in balance_dirty_pages() under heavy IO (creating sparse files).
| 
| balance_dirty_pages() attempts to write out the dirty pages via
| gfs2_writepages() but none are found because these dirty pages are
| being used by the journaling code in the ail. Normally, the journal
| has an upper threshold which when hit triggers an automatic flush
| of the ail. But this threshold can be higher than the number of
| allowable dirty pages and result in the ail never being flushed.
| 
| This patch forces an ail flush when gfs2_writepages() fails to write
| anything. This is a good indication that the ail might be holding
| some dirty pages.
| 
| Resolves: rhbz#1389079
| Signed-off-by: Abhi Das <adas@redhat.com>
| ---
|  fs/gfs2/aops.c   | 14 +++++++++++++-
|  fs/gfs2/incore.h |  1 +
|  fs/gfs2/log.c    |  4 ++++
|  3 files changed, 18 insertions(+), 1 deletion(-)
Hi,

Looks good. This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=9513f7bd924e64b4a75bdb99f6d85027b799e1ba

Regards,

Bob Peterson
Red Hat File Systems



      reply	other threads:[~2017-08-04 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 16:40 [Cluster-devel] [PATCH] gfs2: forcibly flush ail to relieve memory pressure Abhi Das
2017-08-04 17:21 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2033509119.38883626.1501867304650.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).