cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Ondrej Mular <omular@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fence_ipmilan: send empty password, if password is not entered
Date: Thu, 3 Apr 2014 08:44:19 -0400 (EDT)	[thread overview]
Message-ID: <2059981226.1362765.1396529059646.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1889953536.1361192.1396528736901.JavaMail.zimbra@redhat.com>

Previously, agent stuck on password prompt from ipmitool, if password was not specified.

Resolves: rhbz#1083600

---
 fence/agents/ipmilan/fence_ipmilan.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fence/agents/ipmilan/fence_ipmilan.py b/fence/agents/ipmilan/fence_ipmilan.py
index 1e52ccc..632f13d 100644
--- a/fence/agents/ipmilan/fence_ipmilan.py
+++ b/fence/agents/ipmilan/fence_ipmilan.py
@@ -91,6 +91,8 @@ def create_command(options, action):
 	# --password / -p
 	if options.has_key("--password"):
 		cmd += " -P " + quote(options["--password"])
+	else:
+		cmd += " -P ''"
 
 	# --cipher / -C
 	cmd += " -C " + options["--cipher"]
-- 
1.8.3.1



           reply	other threads:[~2014-04-03 12:44 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1889953536.1361192.1396528736901.JavaMail.zimbra@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2059981226.1362765.1396529059646.JavaMail.zimbra@redhat.com \
    --to=omular@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).