cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/2] Improve throughput through rgrp sharing (v2)
Date: Wed, 9 May 2018 09:06:31 +0100	[thread overview]
Message-ID: <216c959c-5e7b-8dc6-ddb1-0f09b3c97ad2@redhat.com> (raw)
In-Reply-To: <20180508200432.24228-1-rpeterso@redhat.com>

Hi,


On 08/05/18 21:04, Bob Peterson wrote:
> Hi,
>
> On 18 April, I posted v1 of this patch set. The idea is to allow multiple
> processes on a node to share a glock that's held exclusively in order to
> improve performance. Sharing rgrps allows for better throughput by
> reducing contention.
>
> Version 1 implemented this by introducing a new glock mode for sharing
> glocks. Steve Whitehouse suggested we didn't need a new mode: we can
> accomplish the same thing just by having a new glock flag, which also
> makes the patch more simple.
>
> This version 2 patch set implements Steve's suggestion.
>
> The first patch introduces the new glock flag. The second patch puts
> it into use for rgrp sharing. Exclusive access to the rgrp is implemented
> through an rwsem.
>
> Performance testing using iozone looks even better than version 1.
Sounds really good! We should make sure that we give this a really good 
round of testing and it would be nice to see some details of the 
performance improvements. Overall though, that's an excellent result :-)

Steve.

> ---
> Bob Peterson (2):
>    GFS2: Introduce GLF_EX_SHARING bit: local EX sharing
>    GFS2: Take advantage of new EXSH glock mode for rgrps
>
>   fs/gfs2/bmap.c   |   2 +-
>   fs/gfs2/dir.c    |   2 +-
>   fs/gfs2/glock.c  |  23 ++++++++++---
>   fs/gfs2/glock.h  |   4 +++
>   fs/gfs2/incore.h |   2 ++
>   fs/gfs2/inode.c  |   7 ++--
>   fs/gfs2/rgrp.c   | 103 ++++++++++++++++++++++++++++++++++++++++++++++---------
>   fs/gfs2/rgrp.h   |   2 +-
>   fs/gfs2/super.c  |   8 +++--
>   fs/gfs2/xattr.c  |   8 +++--
>   10 files changed, 129 insertions(+), 32 deletions(-)
>



      parent reply	other threads:[~2018-05-09  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 20:04 [Cluster-devel] [PATCH 0/2] Improve throughput through rgrp sharing (v2) Bob Peterson
2018-05-08 20:04 ` [Cluster-devel] [PATCH 1/2] GFS2: Introduce GLF_EX_SHARING bit: local EX sharing Bob Peterson
2018-05-08 20:04 ` [Cluster-devel] [PATCH 2/2] GFS2: Take advantage of new EXSH glock mode for rgrps Bob Peterson
2018-05-09  8:06 ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=216c959c-5e7b-8dc6-ddb1-0f09b3c97ad2@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).