From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 12 Jan 2017 11:02:00 -0500 (EST) Subject: [Cluster-devel] [PATCH 5/5] gfs2_edit: Fix unaligned accesses due to saved_metablock size In-Reply-To: <20170110143446.14419-6-anprice@redhat.com> References: <20170110143446.14419-1-anprice@redhat.com> <20170110143446.14419-6-anprice@redhat.com> Message-ID: <245600883.10033195.1484236920767.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | Each saved block is prefixed by a saved_metablock structure that holds | its block number and data length. Unfortunately this structure is 10 | bytes in size, which means that storing the metadata header in memory | immediately following it causes accesses to the header fields to be | unaligned. This causes testsuite failures on sparc64. Instead, on | restore, use a separate buffer for the block data to ensure aligned | accesses to those fields. | | Reported-By: Valentin Vidic | Signed-off-by: Andrew Price | --- Hi, ACK Bob Peterson Red Hat File Systems