From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 4/8] mkfs.gfs2: Set the rg_skip field in new rgrps
Date: Thu, 7 Dec 2017 08:29:01 -0500 (EST) [thread overview]
Message-ID: <260744929.39449540.1512653341360.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20171207115339.3797-5-anprice@redhat.com>
----- Original Message -----
| This field is the difference between the block address of a rgrp and the
| next one. Includes a test to check the rg_skip field against the rindex.
|
| Signed-off-by: Andrew Price <anprice@redhat.com>
| ---
(snip)
| @@ -615,6 +616,9 @@ lgfs2_rgrp_t lgfs2_rgrps_append(lgfs2_rgrps_t rgs, struct
| gfs2_rindex *entry)
| rg->rg.rg_header.mh_type = GFS2_METATYPE_RG;
| rg->rg.rg_header.mh_format = GFS2_FORMAT_RG;
| rg->rg.rg_free = rg->ri.ri_data;
| +#ifdef GFS2_HAS_RG_SKIP
| + rg->rg.rg_skip = rg_skip;
| +#endif
We may still want to initialize the value of rg_skip if the #ifdef is false.
The rest looked good.
Bob Peterson
next prev parent reply other threads:[~2017-12-07 13:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 11:53 [Cluster-devel] [PATCH 0/8] gfs2-utils: Add support for new resource group fields Andrew Price
2017-12-07 11:53 ` [Cluster-devel] [PATCH 1/8] gfs2-utils configure: Check for rg_skip Andrew Price
2017-12-07 11:53 ` [Cluster-devel] [PATCH 2/8] libgfs2: Add rgrp_skip support Andrew Price
2017-12-07 11:53 ` [Cluster-devel] [PATCH 3/8] mkfs.gfs2: Pull place_journals() out of place_rgrps() Andrew Price
2017-12-07 11:53 ` [Cluster-devel] [PATCH 4/8] mkfs.gfs2: Set the rg_skip field in new rgrps Andrew Price
2017-12-07 13:29 ` Bob Peterson [this message]
2017-12-07 14:14 ` Andrew Price
2017-12-07 11:53 ` [Cluster-devel] [PATCH 5/8] gfs2-utils configure: Check for rg_data0, rg_data and rg_bitbytes Andrew Price
2017-12-07 13:29 ` Bob Peterson
2017-12-07 11:53 ` [Cluster-devel] [PATCH 6/8] libgfs2: Add support " Andrew Price
2017-12-07 13:30 ` Bob Peterson
2017-12-07 11:53 ` [Cluster-devel] [PATCH 7/8] mkfs.gfs2: Set the rg_data0, rg_data and rg_bitbytes fields Andrew Price
2017-12-07 13:31 ` Bob Peterson
2017-12-07 11:53 ` [Cluster-devel] [PATCH 8/8] libgfs2: Add support for rg_crc Andrew Price
2017-12-07 12:06 ` Steven Whitehouse
2017-12-07 13:53 ` Bob Peterson
2017-12-07 15:42 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=260744929.39449540.1512653341360.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox