From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Mon, 18 Mar 2019 13:18:19 +0000 Subject: [Cluster-devel] [PATCH 1/2] gfs2: Convert gfs2 to fs_context In-Reply-To: <20190317174027.15291-2-anprice@redhat.com> References: <20190317174027.15291-2-anprice@redhat.com> <20190317174027.15291-1-anprice@redhat.com> Message-ID: <28293.1552915099@warthog.procyon.org.uk> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Andrew Price wrote: > sget() is still used instead of sget_fc() as there doesn't seem to be an > obvious replacement for the bdev pointer propagation to the test/set > functions (yet?) Umm... What about the fs_context struct? Why can't that be used to propagate the bdev pointer? That's kind of what it's for... struct super_block *sget_fc( struct fs_context *fc, int (*test)(struct super_block *, struct fs_context *), int (*set)(struct super_block *, struct fs_context *)) It looks like you should be able to stash the bdev pointer in the gfs2_args struct. > + fsparam_s32 ("commit", Opt_commit), > + fsparam_s32 ("statfs_quantum", Opt_statfs_quantum), > + fsparam_s32 ("statfs_percent", Opt_statfs_percent), Why s32? Why not u32? David