From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio M. Di Nitto Date: Tue, 25 Oct 2011 14:09:03 +0200 Subject: [Cluster-devel] [PATCH 12/19] config: fix return checks in ldap loader In-Reply-To: <1319544550-18366-1-git-send-email-fdinitto@redhat.com> References: <1319544550-18366-1-git-send-email-fdinitto@redhat.com> Message-ID: <2904769170c70aba6ab5200a4d9d49c64c37abf3.1319544159.git.fdinitto@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 fb25af4... 49c30b7... M config/plugins/ldap/configldap.c config/plugins/ldap/configldap.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/config/plugins/ldap/configldap.c b/config/plugins/ldap/configldap.c index fb25af4..49c30b7 100644 --- a/config/plugins/ldap/configldap.c +++ b/config/plugins/ldap/configldap.c @@ -216,6 +216,8 @@ static int read_config_for(LDAP *ld, struct objdb_iface_ver0 *objdb, hdb_handle_ struct berval **val_ber; val_ber = ldap_get_values_len(ld, e, attr); + if (!val_ber) + goto ldap_next; i=0; while (val_ber[i]) { /* @@ -244,9 +246,10 @@ static int read_config_for(LDAP *ld, struct objdb_iface_ver0 *objdb, hdb_handle_ } i++; } + ldap_value_free_len(val_ber); +ldap_next: ldap_memfree(attr); attr = ldap_next_attribute(ld, e, attr_ber); - ldap_value_free_len(val_ber); } ldap_memfree(attr); ber_free(attr_ber, 0); -- 1.7.4.4