From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Date: Wed, 25 Apr 2018 00:18:40 +0200 Subject: [Cluster-devel] vmalloc with GFP_NOFS In-Reply-To: <20180424192803.GT17484@dhcp22.suse.cz> References: <20180424162712.GL17484@dhcp22.suse.cz> <3732370.1623zxSvNg@blindfold> <20180424192803.GT17484@dhcp22.suse.cz> Message-ID: <3894056.cxOY6eVYVp@blindfold> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Am Dienstag, 24. April 2018, 21:28:03 CEST schrieb Michal Hocko: > > Also only for debugging. > > Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem. > > I can prepare a patch. > > Cool! > > Anyway, if UBIFS has some reclaim recursion critical sections in general > it would be really great to have them documented and that is where the > scope api is really handy. Just add the scope and document what is the > recursion issue. This will help people reading the code as well. Ideally > there shouldn't be any explicit GFP_NOFS in the code. So in a perfect world a filesystem calls memalloc_nofs_save/restore and always uses GFP_KERNEL for kmalloc/vmalloc? Thanks, //richard