* [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
@ 2011-08-10 18:13 Chris Feist
2011-08-11 0:44 ` Lon Hohberger
0 siblings, 1 reply; 6+ messages in thread
From: Chris Feist @ 2011-08-10 18:13 UTC (permalink / raw)
To: cluster-devel.redhat.com
Patch to fix common rgmanager scripts for use with pacemaker.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fixed-scripts-for-use-with-rgmanager.patch
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20110810/c7e29732/attachment.ksh>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
2011-08-10 18:13 [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager Chris Feist
@ 2011-08-11 0:44 ` Lon Hohberger
2011-08-11 2:28 ` Chris Feist
0 siblings, 1 reply; 6+ messages in thread
From: Lon Hohberger @ 2011-08-11 0:44 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Wed, Aug 10, 2011 at 01:13:12PM -0500, Chris Feist wrote:
> Patch to fix common rgmanager scripts for use with pacemaker.
Oops... NACK
> 12 files changed, 53 insertions(+), 11 deletions(-)
> mode change 100644 => 100755 rgmanager/src/resources/apache.sh
> mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
> mode change 100644 => 100755 rgmanager/src/resources/ip.sh
> mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
> mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
> mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
> mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
> mode change 100644 => 100755 rgmanager/src/resources/utils/httpd-parse-config.pl
Modes didn't need to be changed.
> + clog_service_status $CLOG_FAILED "$APAHCE_pid_file"
Typo ... APACHE
> status_check_pid "$MYSQL_pid_file"
> + case $? in
> + $OCF_NOT_RUNNING)
> + clog_service_status $CLOG_FAILED "$MYSL_pid_file"
Typo ... MYSQL (happens twice in your patch)
Otherwise, good by me.
--
Lon Hohberger - Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
2011-08-11 0:44 ` Lon Hohberger
@ 2011-08-11 2:28 ` Chris Feist
2011-08-11 2:56 ` Chris Feist
2011-08-11 3:57 ` Fabio M. Di Nitto
0 siblings, 2 replies; 6+ messages in thread
From: Chris Feist @ 2011-08-11 2:28 UTC (permalink / raw)
To: cluster-devel.redhat.com
> > 12 files changed, 53 insertions(+), 11 deletions(-)
> > mode change 100644 => 100755 rgmanager/src/resources/apache.sh
> > mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
> > mode change 100644 => 100755 rgmanager/src/resources/ip.sh
> > mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
> > mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
> > mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
> > mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
> > mode change 100644 => 100755
> > rgmanager/src/resources/utils/httpd-parse-config.pl
>
> Modes didn't need to be changed.
Modes need to be changed to pass ocf_tester (it's one of the tests), should we just skip this?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
2011-08-11 2:28 ` Chris Feist
@ 2011-08-11 2:56 ` Chris Feist
2011-08-12 1:18 ` Lon Hohberger
2011-08-11 3:57 ` Fabio M. Di Nitto
1 sibling, 1 reply; 6+ messages in thread
From: Chris Feist @ 2011-08-11 2:56 UTC (permalink / raw)
To: cluster-devel.redhat.com
> > > 12 files changed, 53 insertions(+), 11 deletions(-)
> > > mode change 100644 => 100755 rgmanager/src/resources/apache.sh
> > > mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
> > > mode change 100644 => 100755 rgmanager/src/resources/ip.sh
> > > mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
> > > mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
> > > mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
> > > mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
> > > mode change 100644 => 100755
> > > rgmanager/src/resources/utils/httpd-parse-config.pl
> >
> > Modes didn't need to be changed.
>
> Modes need to be changed to pass ocf_tester (it's one of the tests),
> should we just skip this?
Looking at the heartbeat agents they all are executable in the source, should we try to match that with the agents we've converted? Or should we just keep them as is? The only issue is that then we can't fully test the ocf_tester until after we install.
Thanks,
Chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
2011-08-11 2:56 ` Chris Feist
@ 2011-08-12 1:18 ` Lon Hohberger
0 siblings, 0 replies; 6+ messages in thread
From: Lon Hohberger @ 2011-08-12 1:18 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Wed, Aug 10, 2011 at 10:56:38PM -0400, Chris Feist wrote:
> > > > 12 files changed, 53 insertions(+), 11 deletions(-)
> > > > mode change 100644 => 100755 rgmanager/src/resources/apache.sh
> > > > mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
> > > > mode change 100644 => 100755 rgmanager/src/resources/ip.sh
> > > > mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
> > > > mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
> > > > mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
> > > > mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
> > > > mode change 100644 => 100755
> > > > rgmanager/src/resources/utils/httpd-parse-config.pl
> > >
> > > Modes didn't need to be changed.
> >
> > Modes need to be changed to pass ocf_tester (it's one of the tests),
> > should we just skip this?
>
> Looking at the heartbeat agents they all are executable in the source, should we try to match that with the agents we've converted? Or should we just keep them as is? The only issue is that then we can't fully test the ocf_tester until after we install.
>
This is fine -- testing from the source tree is a valid thing to do.
--
Lon Hohberger - Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
2011-08-11 2:28 ` Chris Feist
2011-08-11 2:56 ` Chris Feist
@ 2011-08-11 3:57 ` Fabio M. Di Nitto
1 sibling, 0 replies; 6+ messages in thread
From: Fabio M. Di Nitto @ 2011-08-11 3:57 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 08/11/2011 04:28 AM, Chris Feist wrote:
>
>>> 12 files changed, 53 insertions(+), 11 deletions(-)
>>> mode change 100644 => 100755 rgmanager/src/resources/apache.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/ip.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
>>> mode change 100644 => 100755
>>> rgmanager/src/resources/utils/httpd-parse-config.pl
>>
>> Modes didn't need to be changed.
>
> Modes need to be changed to pass ocf_tester (it's one of the tests), should we just skip this?
>
It makes sense to be able to test within the source tree too. At the
time those files were set 0644, we had no test and no use case to keep
them executable within the source. Now we do. ACK from me.
The agents are installed 0755 in /usr/share/cluster by Makefile targets.
Can you please cross check if also utils/httpd-parse-config.pl is 0755
once installed? If not we need to fix that in utils/Makefile.am.
Fabio
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-12 1:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-10 18:13 [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager Chris Feist
2011-08-11 0:44 ` Lon Hohberger
2011-08-11 2:28 ` Chris Feist
2011-08-11 2:56 ` Chris Feist
2011-08-12 1:18 ` Lon Hohberger
2011-08-11 3:57 ` Fabio M. Di Nitto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).