* [Cluster-devel] [PATCH] dlm: Don't delete misc device if lockspace removal fails
@ 2007-03-21 9:23 Patrick Caulfield
2007-03-22 11:24 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Caulfield @ 2007-03-21 9:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
Currently if the lockspace removal fails the misc device associated with a
lockspace is left deleted. After that there is no way to access the orphaned
lockspace from userland.
This patch recreates the misc device if th dlm_release_lockspace fails. I
believe this is better than attempting to remove the lockspace first because
that leaves an unattached device lying around. The potential gap in which there
is no access to the lockspace between removing the misc device and recreating it
is acceptable ... after all the application is trying to remove it, and only new
users of the lockspace will be affected.
Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
--
patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: device.patch
Type: text/x-patch
Size: 2438 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070321/bd75c92b/attachment.bin>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Cluster-devel] [PATCH] dlm: Don't delete misc device if lockspace removal fails
2007-03-21 9:23 [Cluster-devel] [PATCH] dlm: Don't delete misc device if lockspace removal fails Patrick Caulfield
@ 2007-03-22 11:24 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2007-03-22 11:24 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the GFS2 -nmw git tree. Thanks,
Steve.
On Wed, 2007-03-21 at 09:23 +0000, Patrick Caulfield wrote:
> Currently if the lockspace removal fails the misc device associated with a
> lockspace is left deleted. After that there is no way to access the orphaned
> lockspace from userland.
>
> This patch recreates the misc device if th dlm_release_lockspace fails. I
> believe this is better than attempting to remove the lockspace first because
> that leaves an unattached device lying around. The potential gap in which there
> is no access to the lockspace between removing the misc device and recreating it
> is acceptable ... after all the application is trying to remove it, and only new
> users of the lockspace will be affected.
>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-22 11:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-21 9:23 [Cluster-devel] [PATCH] dlm: Don't delete misc device if lockspace removal fails Patrick Caulfield
2007-03-22 11:24 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).