[Cluster-devel] Problems with recent Makefile changes

[Cluster-devel] Problems with recent Makefile changes

[Robert Peterson]

Hi Fabio,

I did find a couple problems with your new changes to the Makefiles
for cluster suite.  The first problem is that the gfs2 userland tools
don't have a dependency set for ../libgfs2/libgfs2.a.  So if you
change a function in libgfs2 and recompile, the userland tools never
know to link in the modified libgfs2.a library.

The second problem I ran into yesterday.  Basically, I compiled a 
gfs2 userland tool and got a compiler error.  I fixed the error
and replaced the file.  However, my second compile--which should have
been successful--failed with some odd error message.  After I did 
"make clean" and "make" again, it worked.  I should have gotten more 
info at the time, but unfortunately, I didn't because I was in a hurry.  
If I run across this again, I'll try to get more information about
what's happening.

Regards,

Bob Peterson
Red Hat Cluster Suite

[Cluster-devel] Re: Problems with recent Makefile changes

[Fabio Massimo Di Nitto]

Robert Peterson wrote:
> Hi Fabio,
> 
> I did find a couple problems with your new changes to the Makefiles
> for cluster suite.  The first problem is that the gfs2 userland tools
> don't have a dependency set for ../libgfs2/libgfs2.a. 
> So if you
> change a function in libgfs2 and recompile, the userland tools never
> know to link in the modified libgfs2.a library.

Yes, this was/is in the TODO list from my first email. Each subproject requires
to have explicit dependencies. It's a really long monkey job but i will get to it.

> The second problem I ran into yesterday.  Basically, I compiled a 
> gfs2 userland tool and got a compiler error.  I fixed the error
> and replaced the file.  However, my second compile--which should have
> been successful--failed with some odd error message.  After I did 
> "make clean" and "make" again, it worked.  I should have gotten more 
> info at the time, but unfortunately, I didn't because I was in a hurry.  
> If I run across this again, I'll try to get more information about
> what's happening.

It would be lovely if you could show me the full error next time it happens
and if you have a way to reproduce it.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.

[Cluster-devel] Re: Problems with recent Makefile changes

[Fabio Massimo Di Nitto]

Hi Robert,

Robert Peterson wrote:
> Hi Fabio,
> 
> I did find a couple problems with your new changes to the Makefiles
> for cluster suite.  The first problem is that the gfs2 userland tools
> don't have a dependency set for ../libgfs2/libgfs2.a.  So if you
> change a function in libgfs2 and recompile, the userland tools never
> know to link in the modified libgfs2.a library.

could you be so kind to test the patch in attachment and see if it fulfill your
needs in this respect?

the patch is against CVS HEAD and only gfs2/. I still plan to do all the other
subprojects, but I would like comments first on this one.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gfs2.diff
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070503/ecb85e5c/attachment.ksh>

[Cluster-devel] Re: Problems with recent Makefile changes

[Robert Peterson]

Fabio Massimo Di Nitto wrote:
> It would be lovely if you could show me the full error next time it happens
> and if you have a way to reproduce it.
> 
> Thanks
> Fabio
> 
Hi Fabio,

The problem seems to be that all the include files are somehow specified on 
the gcc command if only one file changes.  Thus, if I change rgrp.c and do 
a make, I get:

[root at trin-10 ../cluster/gfs/gfs_fsck]# make
gcc -Wall -I/home/devel/HEAD.intermediate/cluster/config -D_FILE_OFFSET_BITS=64 -DHELPER_PROGRAM -DGFS_RELEASE_NAME=\"DEVEL.1178030462\" -MMD -O2 -I../include -c -o rgrp.o rgrp.c util.h fsck_incore.h ondisk.h ../include/osi_list.h ../include/osi_user.h ../include/global.h ../include/linux_endian.h fs_bits.h rgrp.h fsck.h log.h block_list.h bitmap.h bio.h fs_inode.h inode.h
gcc: cannot specify -o with -c or -S with multiple files
make: *** [rgrp.o] Error 1

However, I can do "make clean ; make" and it works just fine. 
This is a gfs userland example, but I think gfs2 is the same.

Regards,

Bob Peterson
Red Hat Cluster Suite

[Cluster-devel] Re: Problems with recent Makefile changes

[Fabio Massimo Di Nitto]

Robert Peterson wrote:
> Fabio Massimo Di Nitto wrote:
>> It would be lovely if you could show me the full error next time it happens
>> and if you have a way to reproduce it.
>>
>> Thanks
>> Fabio
>>
> Hi Fabio,
> 
> The problem seems to be that all the include files are somehow specified on 
> the gcc command if only one file changes.  Thus, if I change rgrp.c and do 
> a make, I get:
> 
> [root at trin-10 ../cluster/gfs/gfs_fsck]# make
> gcc -Wall -I/home/devel/HEAD.intermediate/cluster/config -D_FILE_OFFSET_BITS=64 -DHELPER_PROGRAM -DGFS_RELEASE_NAME=\"DEVEL.1178030462\" -MMD -O2 -I../include -c -o rgrp.o rgrp.c util.h fsck_incore.h ondisk.h ../include/osi_list.h ../include/osi_user.h ../include/global.h ../include/linux_endian.h fs_bits.h rgrp.h fsck.h log.h block_list.h bitmap.h bio.h fs_inode.h inode.h
> gcc: cannot specify -o with -c or -S with multiple files
> make: *** [rgrp.o] Error 1
> 
> However, I can do "make clean ; make" and it works just fine. 
> This is a gfs userland example, but I think gfs2 is the same.
> 
> Regards,
> 
> Bob Peterson
> Red Hat Cluster Suite

This is pretty special, but i am ready to bet that you have seen the problem
only in gfs/gfs_fsck and gfs2/fsck and I am now able to reproduce this by
issuing twice in a row:
make clean all

I am going to investigate it, but I would like to know if there is a special
reason why we use -MMD and -include for *.d files (that are actually leaked in
the above command and hence the world fall apart in an endless blackhole).

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.

[Cluster-devel] Re: Problems with recent Makefile changes

[Alasdair G Kergon]

On Thu, May 03, 2007 at 04:52:47PM +0200, Fabio Massimo Di Nitto wrote:
> Robert Peterson wrote:
> > Fabio Massimo Di Nitto wrote:
> > [root at trin-10 ../cluster/gfs/gfs_fsck]# make
> > gcc -Wall -I/home/devel/HEAD.intermediate/cluster/config -D_FILE_OFFSET_BITS=64 -DHELPER_PROGRAM -DGFS_RELEASE_NAME=\"DEVEL.1178030462\" -MMD -O2 -I../include -c -o rgrp.o rgrp.c util.h fsck_incore.h ondisk.h ../include/osi_list.h ../include/osi_user.h ../include/global.h ../include/linux_endian.h fs_bits.h rgrp.h fsck.h log.h block_list.h bitmap.h bio.h fs_inode.h inode.h
> > gcc: cannot specify -o with -c or -S with multiple files
> > make: *** [rgrp.o] Error 1
> > 

I can see some '$^' that I think should be '$<'.
(Then that particular problem goes away for me.)

Also I notice some missing .PHONY: It's searching for the file called 'all' for
example.

Alasdair
-- 
agk@redhat.com

[Cluster-devel] Re: Problems with recent Makefile changes

[Fabio Massimo Di Nitto]

Alasdair G Kergon wrote:
> On Thu, May 03, 2007 at 04:52:47PM +0200, Fabio Massimo Di Nitto wrote:
>> Robert Peterson wrote:
>>> Fabio Massimo Di Nitto wrote:
>>> [root at trin-10 ../cluster/gfs/gfs_fsck]# make
>>> gcc -Wall -I/home/devel/HEAD.intermediate/cluster/config -D_FILE_OFFSET_BITS=64 -DHELPER_PROGRAM -DGFS_RELEASE_NAME=\"DEVEL.1178030462\" -MMD -O2 -I../include -c -o rgrp.o rgrp.c util.h fsck_incore.h ondisk.h ../include/osi_list.h ../include/osi_user.h ../include/global.h ../include/linux_endian.h fs_bits.h rgrp.h fsck.h log.h block_list.h bitmap.h bio.h fs_inode.h inode.h
>>> gcc: cannot specify -o with -c or -S with multiple files
>>> make: *** [rgrp.o] Error 1
>>>
> 
> I can see some '$^' that I think should be '$<'.
> (Then that particular problem goes away for me.)

Yes it might very well be. I am looking into it.

> Also I notice some missing .PHONY: It's searching for the file called 'all' for
> example.

.PHONY: needs to be redone together with the dependencies stuff reported by
Robert. I posted a patch for RFC on the mailing list before doing the
bulk/monkey work.

Fabio

-- 
I'm going to make him an offer he can't refuse.

[Cluster-devel] Re: Problems with recent Makefile changes

[Fabio Massimo Di Nitto]

Alasdair G Kergon wrote:

> I can see some '$^' that I think should be '$<'.
> (Then that particular problem goes away for me.)

That was it. Thanks a lot for spotting it.

Fix have been committed in CVS a few seconds ago.

Fabio

-- 
I'm going to make him an offer he can't refuse.