From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Peterson Date: Fri, 04 May 2007 16:37:58 -0500 Subject: [Cluster-devel] [PATCH] GFS2: kernel changes to support new gfs2_grow command (Try 3) In-Reply-To: <20070504193714.GB13775@redhat.com> References: <46394174.2030709@redhat.com> <20070504193714.GB13775@redhat.com> Message-ID: <463BA7B6.5020607@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit David Teigland wrote: > So the use of glock_is_held _is_ part of an assertion, not part of an > algorithm which I was worried about before. We should only ever get to > this spot with a shared glock, right? (rindex_hold takes it). So a plain > old assertion that the glock is shared at the beginning would be ok, but > this particular check doesn't make sense to me. See previous email. > Why is this needed now if it wasn't before? Again, this goes back to the partial rinedx entries left on a page in the middle of an rindex update through the meta_fs. We don't want to read in a partial entry, we want to ignore it. Regards, Bob Peterson Red Hat Cluster Suite