[Cluster-devel] [PATCH] dlm: Clear othercon pointers when a connection is closed

[Cluster-devel] [PATCH] dlm: Clear othercon pointers when a connection is closed

[Patrick Caulfield]

This patch clears the othercon pointer and frees the memory when a connnection
is closed. This could cause a small memory leak when nodes leave the cluster.

Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>

Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: othercon3.patch
Type: text/x-patch
Size: 458 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070711/89ed6bc0/attachment.bin>

[Cluster-devel] [PATCH] dlm: Clear othercon pointers when a connection is closed

[Steven Whitehouse]

Hi,

On Wed, 2007-07-11 at 13:39 +0100, Patrick Caulfield wrote:
> This patch clears the othercon pointer and frees the memory when a connnection
> is closed. This could cause a small memory leak when nodes leave the cluster.
> 
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
> 
> Patrick

Now in the GFS2 -nmw git tree. Thanks,

Steve.

[Cluster-devel] [PATCH] [DLM] Clear othercon pointers when a connection is closed

[swhiteho]

From: Patrick Caulfield <pcaulfie@redhat.com>

This patch clears the othercon pointer and frees the memory when a connnection
is closed. This could cause a small memory leak when nodes leave the cluster.

Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index dd36273..d15fd5f 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -327,6 +327,8 @@ static void close_connection(struct connection *con, bool and_other)
 	if (con->othercon && and_other) {
 		/* Will only re-enter once. */
 		close_connection(con->othercon, false);
+		kmem_cache_free(con_cache, con->othercon);
+		con->othercon = NULL;
 	}
 	if (con->rx_page) {
 		__free_page(con->rx_page);
-- 
1.5.1.2