From mboxrd@z Thu Jan 1 00:00:00 1970 From: H. Peter Anvin Date: Sun, 12 Aug 2007 21:27:39 -0700 Subject: [Cluster-devel] Re: [PATCH] gfs2: better code for translating characters In-Reply-To: <91b13c310708122008w27b86359n5b135df3e229e616@mail.gmail.com> References: <11869741183677-git-send-email-crquan@gmail.com> <91b13c310708122008w27b86359n5b135df3e229e616@mail.gmail.com> Message-ID: <46BFDDBB.2020104@zytor.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit rae l wrote: > On 8/13/07, Denis Cheng wrote: >> the original code could work, but I think this code could work better. >> >> Signed-off-by: Denis Cheng >> --- >> fs/gfs2/ops_fstype.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c >> index cf5aa50..b9a7759 100644 >> --- a/fs/gfs2/ops_fstype.c >> +++ b/fs/gfs2/ops_fstype.c >> @@ -145,7 +145,8 @@ static int init_names(struct gfs2_sbd *sdp, int silent) >> snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto); >> snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table); >> >> - while ((table = strchr(sdp->sd_table_name, '/'))) >> + table = sdp->sd_table_name; >> + while ((table = strchr(table, '/'))) >> *table = '_'; > Sorry, I don't know what the while loop really means, what's the > common case that slash character exists? if the '/' appears multiple, > the latter code would be better; however, if slash appears rarely, the > original would still be better. > Only if the compiler is stupid. -hpa