[Cluster-devel] [GFS2] Abort mount if (u)mount helpers are missing

[Cluster-devel] [GFS2] Abort mount if (u)mount helpers are missing

[Fabio Massimo Di Nitto]

Hi Steven,

the patch in attachment is a fix to abort mount if the mount.gfs* and possible
umount.* are missing from /sbin.

While we do what we can to guarantee that they are installed properly in
userland (CVS HEAD), we want to make sure that mount still aborts properly.

The only sign of missing helpers is that lock_dlm will receive no mount options
at all. According to David the problem does not exists for lock_nolock as the
helpers are not required.

The patch has been tested for both gfs and gfs2 and it works as expected. The
lack of mount.gfs* will generate an error that is propagated to mount:

root at node1:~# mount -t  gfs2 /dev/nbd2 /mnt/
mount: wrong fs type, bad option, bad superblock on /dev/nbd2,
       missing codepage or helper program, or other error
       In some cases useful info is found in syslog - try
       dmesg | tail  or so

[ 3513.303346] GFS2: fsid=: Trying to join cluster "lock_dlm", "gutsy:gfs2"
[ 3513.304546] DLM/GFS2/GFS ERROR: (u)mount helpers are not installed properly!
[ 3513.306290] GFS2: fsid=: can't mount proto=lock_dlm, table=gutsy:gfs2, hostdata=

You might want to notice that it will also avoid mount to hang or fail silently
or with strange errors that will require the cluster to reboot/restart before
you can actually mount the filesystem again.

Please apply.

Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: helpers.diff
Type: application/pgp-encrypted
Size: 530 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20071115/f16af495/attachment.pgp>

[Cluster-devel] [GFS2] Abort mount if (u)mount helpers are missing

[Fabio Massimo Di Nitto]

Perhaps attaching the final patch would be even better :)))

Fabio

-- 
I'm going to make him an offer he can't refuse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: helpers.diff
Type: application/pgp-encrypted
Size: 530 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20071115/2d1f517e/attachment.pgp>

[Cluster-devel] [GFS2] Abort mount if (u)mount helpers are missing

[Fabio Massimo Di Nitto]

Fabio Massimo Di Nitto wrote:
> Perhaps attaching the final patch would be even better :)))
> 
> Fabio
> 

I promise.. this is the good one... *sighs*

Fabio

-- 
I'm going to make him an offer he can't refuse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: helpers.diff
Type: application/pgp-encrypted
Size: 532 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20071115/e015e1eb/attachment.pgp>