* [Cluster-devel] [PATCH] gfs2: tidy up error message
@ 2007-11-15 15:01 David Teigland
2007-11-15 15:06 ` Fabio Massimo Di Nitto
2007-11-15 15:15 ` [Cluster-devel] " Steven Whitehouse
0 siblings, 2 replies; 3+ messages in thread
From: David Teigland @ 2007-11-15 15:01 UTC (permalink / raw)
To: cluster-devel.redhat.com
Print error with log_error() to be consistent with others.
Signed-off-by: David Teigland <teigland@redhat.com>
---
fs/gfs2/locking/dlm/mount.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c
index ab30102..f2efff4 100644
--- a/fs/gfs2/locking/dlm/mount.c
+++ b/fs/gfs2/locking/dlm/mount.c
@@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
strncpy(data, data_arg, 255);
if (!strlen(data)) {
- printk(KERN_ERR
- "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
+ log_error("no mount options, (u)mount helpers not installed");
return -EINVAL;
}
--
1.5.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Cluster-devel] [PATCH] gfs2: tidy up error message
2007-11-15 15:01 [Cluster-devel] [PATCH] gfs2: tidy up error message David Teigland
@ 2007-11-15 15:06 ` Fabio Massimo Di Nitto
2007-11-15 15:15 ` [Cluster-devel] " Steven Whitehouse
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Massimo Di Nitto @ 2007-11-15 15:06 UTC (permalink / raw)
To: cluster-devel.redhat.com
Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>
David Teigland wrote:
> Print error with log_error() to be consistent with others.
>
> Signed-off-by: David Teigland <teigland@redhat.com>
> ---
> fs/gfs2/locking/dlm/mount.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c
> index ab30102..f2efff4 100644
> --- a/fs/gfs2/locking/dlm/mount.c
> +++ b/fs/gfs2/locking/dlm/mount.c
> @@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
> strncpy(data, data_arg, 255);
>
> if (!strlen(data)) {
> - printk(KERN_ERR
> - "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
> + log_error("no mount options, (u)mount helpers not installed");
> return -EINVAL;
> }
>
--
I'm going to make him an offer he can't refuse.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] Re: [PATCH] gfs2: tidy up error message
2007-11-15 15:01 [Cluster-devel] [PATCH] gfs2: tidy up error message David Teigland
2007-11-15 15:06 ` Fabio Massimo Di Nitto
@ 2007-11-15 15:15 ` Steven Whitehouse
1 sibling, 0 replies; 3+ messages in thread
From: Steven Whitehouse @ 2007-11-15 15:15 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On Thu, 2007-11-15 at 09:01 -0600, David Teigland wrote:
> Print error with log_error() to be consistent with others.
>
> Signed-off-by: David Teigland <teigland@redhat.com>
> ---
> fs/gfs2/locking/dlm/mount.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c
> index ab30102..f2efff4 100644
> --- a/fs/gfs2/locking/dlm/mount.c
> +++ b/fs/gfs2/locking/dlm/mount.c
> @@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
> strncpy(data, data_arg, 255);
>
> if (!strlen(data)) {
> - printk(KERN_ERR
> - "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
> + log_error("no mount options, (u)mount helpers not installed");
> return -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-15 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-15 15:01 [Cluster-devel] [PATCH] gfs2: tidy up error message David Teigland
2007-11-15 15:06 ` Fabio Massimo Di Nitto
2007-11-15 15:15 ` [Cluster-devel] " Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).