From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Massimo Di Nitto Date: Wed, 28 Nov 2007 22:07:21 +0100 Subject: [Cluster-devel] [PATCH] Fix qdiskd device scanning logic Message-ID: <474DD889.6030801@ubuntu.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Lon, the original idea of scanning /dev was not too bad but after porting it to ocfs2-tools and brainstorming again with the guys, we found a few things that could be done better. Let's change a direct scan of /dev into: - scan /sys/block first for well.. block devices. - sysfs exports enough info for us to filter out removable devices like cdroms that we don't care to even check and to gather maj/min of each device. - scan /dev only to match maj/min and gather the device name. - never dig or attempt to check hidden files. Please review or apply. Joel: once applied on top, this is basically the same code that would land in ocfs2-tools. Thanks Fabio -- I'm going to make him an offer he can't refuse. -------------- next part -------------- A non-text attachment was scrubbed... Name: fix_proc_part_scan.diff Type: application/pgp-encrypted Size: 5980 bytes Desc: not available URL: