From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wendy Cheng Date: Tue, 08 Jan 2008 22:49:17 -0500 Subject: [Cluster-devel] Re: [PATCH 1/2] NLM failover unlock commands In-Reply-To: <20080108170220.GA21401@infradead.org> References: <4781BB0D.90706@redhat.com> <20080108170220.GA21401@infradead.org> Message-ID: <4784443D.4070801@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Christoph Hellwig wrote: >>+/* cluster failover support */ >>+ >>+typedef struct { >>+ int cmd; >>+ int stat; >>+ int gp; >>+ void *datap; >>+} nlm_fo_cmd; >> >> > >please don't introduce typedefs for struct types. > > I don't do much community version of linux code so its coding standard is new to me. Any reason for this (not doing typedefs) ? -- Wendy