From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Caulfeld Date: Fri, 18 Jan 2008 08:27:03 +0000 Subject: [Cluster-devel] [PATCH] dlm close othercons In-Reply-To: References: <4784E2F3.5040508@redhat.com> Message-ID: <479062D7.6020805@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Fabio M. Di Nitto wrote: > On Wed, 9 Jan 2008, Patrick Caulfeld wrote: > >> This patch addresses a problem introduced with the last round of >> lowcomms patches where the 'othercon' connections do not get freed when >> the DLM shuts down. >> >> This results in the error message >> "slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all >> objects" >> >> and the DLM cannot be restarted without a system reboot. >> >> See bz#428119 >> >> Signed-Off-By: Patrick Caulfield >> > > http://git.kernel.org/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=89f0bb2873fcaa8e57831dd3f0c013cabbd99012 > > > this doesn't look right... > > shouldn't we free the con->other _before_ we free con? > > That's what we were doing before applying all that patch set that > removed the original kmem_cache_free... > ARGH! you're right, of course. Patch to fix is attached. Thanks Fabio, I'm glad that someone reads my patches ... I just wish it had been me ;-) Patrick Signed-off-by: Patrick Caulfield -------------- next part -------------- A non-text attachment was scrubbed... Name: free2.patch Type: text/x-patch Size: 428 bytes Desc: not available URL: