From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] DLM: Do not count redundant connection attempts against retries
Date: Thu, 20 Apr 2017 16:02:20 -0400 (EDT) [thread overview]
Message-ID: <483789947.17531984.1492718540635.JavaMail.zimbra@redhat.com> (raw)
Hi,
Before this patch, multiple GFS2 mounts would result in multiple
connection attempts. They were all ignored, and rightly so, but
they were being counted against the connection attempt retries.
This patch moves the retry check later those redundant attempts
are simply ignored, as they should be.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 7d398d3..42c8457 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1123,13 +1123,13 @@ static void tcp_connect_to_sock(struct connection *con)
}
mutex_lock(&con->sock_mutex);
- if (con->retries++ > MAX_CONNECT_RETRIES)
- goto out;
-
/* Some odd races can cause double-connects, ignore them */
if (con->sock)
goto out;
+ if (con->retries++ > MAX_CONNECT_RETRIES)
+ goto out;
+
/* Create a socket to communicate with */
result = sock_create_kern(&init_net, dlm_local_addr[0]->ss_family,
SOCK_STREAM, IPPROTO_TCP, &sock);
next reply other threads:[~2017-04-20 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 20:02 Bob Peterson [this message]
2017-04-20 20:33 ` [Cluster-devel] DLM: Do not count redundant connection attempts against retries David Teigland
2017-04-24 12:37 ` Bob Peterson
2017-04-24 13:52 ` Christine Caulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483789947.17531984.1492718540635.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).