From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Date: Sun, 11 Dec 2022 14:03:57 +0800 Subject: [Cluster-devel] [f2fs-dev] [PATCH v4 16/23] f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() In-Reply-To: <20221102161031.5820-17-vishal.moola@gmail.com> References: <20221102161031.5820-1-vishal.moola@gmail.com> <20221102161031.5820-17-vishal.moola@gmail.com> Message-ID: <489f2daa-4559-6c32-71e2-8bab65fb8154@kernel.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2022/11/3 0:10, Vishal Moola (Oracle) wrote: > Convert function to use folios throughout. This is in preparation for the > removal of find_get_pages_range_tag(). This change removes 5 calls to > compound_head(). > > Initially the function was checking if the previous page index is truly the > previous page i.e. 1 index behind the current page. To convert to folios and > maintain this check we need to make the check > folio->index != prev + folio_nr_pages(previous folio) since we don't know > how many pages are in a folio. > > At index i == 0 the check is guaranteed to succeed, so to workaround indexing > bounds we can simply ignore the check for that specific index. This makes the > initial assignment of prev trivial, so I removed that as well. > > Also modified a comment in commit_checkpoint for consistency. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Chao Yu Thanks,