From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Thu, 27 Aug 2015 09:34:57 -0400 (EDT)
Subject: [Cluster-devel] [GFS2 PATCH 2/2] GFS2: Use resizable hash table
 for glocks
In-Reply-To: <CAHc6FU6qeyvULZt=fKoNGZWdfduHypaEEGhMV3DTKVfWZ_d-kA@mail.gmail.com>
References: <1436466345-11383-1-git-send-email-rpeterso@redhat.com>
	<1436466345-11383-3-git-send-email-rpeterso@redhat.com>
	<CAHc6FU6qeyvULZt=fKoNGZWdfduHypaEEGhMV3DTKVfWZ_d-kA@mail.gmail.com>
Message-ID: <498757425.18274950.1440682497407.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

----- Original Message -----
> Bob,
> 
> 2015-07-09 20:25 GMT+02:00 Bob Peterson <rpeterso@redhat.com>:
> > @@ -202,9 +176,8 @@ void gfs2_glock_put(struct gfs2_glock *gl)
> >
> >         gfs2_glock_remove_from_lru(gl);
> >         spin_unlock(&gl->gl_lockref.lock);
> > -       spin_lock_bucket(gl->gl_hash);
> > -       hlist_bl_del_rcu(&gl->gl_list);
> > -       spin_unlock_bucket(gl->gl_hash);
> > +       if (gl->gl_node.next != NULL)
> > +               rhashtable_remove_fast(&gl_hash_table, &gl->gl_node,
> > ht_parms);
> >         GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders));
> >         GLOCK_BUG_ON(gl, mapping && mapping->nrpages);
> >         trace_gfs2_glock_put(gl);
> 
> what does the added if do?
 
I guess nothing. I'll remove it with another patch.

Bob Peterson
Red Hat File Systems