cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] resource-agents: Try force-unmount before fuser for netfs.sh
Date: Tue, 22 Mar 2011 09:34:26 +0100	[thread overview]
Message-ID: <4D885F12.6060608@redhat.com> (raw)
In-Reply-To: <1300756035-9404-1-git-send-email-lhh@redhat.com>

ACK.

Fabio

On 3/22/2011 2:07 AM, Lon Hohberger wrote:
> RHEL5 only.  A completely separate patch is needed for
> upstream and RHEL6
> 
> Resolves: rhbz#678494
> 
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
>  rgmanager/src/resources/netfs.sh |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/rgmanager/src/resources/netfs.sh b/rgmanager/src/resources/netfs.sh
> index 1a669d3..837a4c4 100755
> --- a/rgmanager/src/resources/netfs.sh
> +++ b/rgmanager/src/resources/netfs.sh
> @@ -486,6 +486,7 @@ stopNFSFilesystem() {
>  	typeset no_umount=""
>  	typeset force_umount=""
>  	typeset fstype=""
> +	typeset umount_flag=""
>  
>  
>  	#
> @@ -558,7 +559,7 @@ stopNFSFilesystem() {
>  			sync; sync; sync
>  			ocf_log info "unmounting $mp"
>  
> -                        umount $mp
> +                        umount $umount_flag $mp
>  			if  [ $? -eq 0 ]; then
>                                  umount_failed=
>                                  done=$YES
> @@ -568,6 +569,10 @@ stopNFSFilesystem() {
>  			umount_failed=yes
>  
>  			if [ "$force_umount" ]; then
> +				if [ -z "$umount_flag" ]; then
> +					umount_flag="-f"
> +					continue
> +				fi
>  				if [ $try -eq 1 ]; then
>  					fuser -TERM -kvm "$mp"
>  				else



      reply	other threads:[~2011-03-22  8:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22  1:07 [Cluster-devel] [PATCH] resource-agents: Try force-unmount before fuser for netfs.sh Lon Hohberger
2011-03-22  8:34 ` Fabio M. Di Nitto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D885F12.6060608@redhat.com \
    --to=fdinitto@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).