From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christine Caulfield Date: Tue, 31 May 2011 08:40:53 +0100 Subject: [Cluster-devel] [PATCH] compare cluster name in cman daemon In-Reply-To: <4DE35928.3050203@openvz.org> References: <4DDCAE8B.2000401@openvz.org> <4DDCB831.9050808@redhat.com> <4DDCBFBE.6080705@openvz.org> <4DE35928.3050203@openvz.org> Message-ID: <4DE49B85.8000806@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 30/05/11 09:45, Evgeniy Sokolov wrote: > On 25.05.2011 12:37, Evgeniy Sokolov wrote: >> On 25.05.2011 12:05, Christine Caulfield wrote: >>> On 25/05/11 08:23, Evgeniy Sokolov wrote: >>>> if length of cluster name = 16, last char of msg->clustername will not >>>> be zero. >>>> In this case strcmp will continue read member fence_agent from >>>> cl_transmsg structure. >>>> >>>> >>> >>> If the length of the cluster name = 16 then there is a bug somewhere >>> else that needs fixing ;-) >>> >>> Chrissie >>> >>> >> >> Design of cl_transmsg->clustername[16] is string with max length 15 + 1 >> char for zero. Is it correct? > > Christine, can you answer the question? Yes, that's correct. Chrissie