From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Add i18n infra-structure.
Date: Wed, 01 Jun 2011 06:28:10 +0200 [thread overview]
Message-ID: <4DE5BFDA.2010404@redhat.com> (raw)
In-Reply-To: <1306870631-27386-1-git-send-email-cmaiolino@redhat.com>
On 05/31/2011 09:37 PM, Carlos Maiolino wrote:
> This patch adds some files, directories and changes in configure.ac and Makefile.am required to i18n support.
>
> The previous patch missed changes in configure.ac and Makefile.am, this is the correct one
>
> ---
> Makefile.am | 4 +-
> config.rpath | 672 ++++++++++++++++++++++++++++++++++++++++++++++++
Why do we need config.rpath? What does it do in this context?
> diff --git a/configure.ac b/configure.ac
> index 3fc02d0..aa7cc64 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -16,6 +16,10 @@ AC_PROG_LIBTOOL
>
> AC_LANG([C])
>
> +#i18n
> +AM_GNU_GETTEXT
> +AM_GNU_GETTEXT_VERSION([0.18])
> +
> # Sanitize path
>
> if test "$prefix" = "NONE"; then
> @@ -262,7 +266,7 @@ CPPFLAGS="$KERNEL_CPPFLAGS -I\$(top_builddir)/make -I\$(top_srcdir)/make \
> -I. $ENV_CPPFLAGS"
> LDFLAGS="$ENV_LDFLAGS"
>
> -AC_CONFIG_FILES([Makefile
> +AC_CONFIG_FILES([Makefile intl/Makefile po/Makefile.in
> group/Makefile
> group/libgfscontrol/Makefile
> group/gfs_control/Makefile
One per line, in alphabetical order please. Easier to track them.
Same applies to Makefile.am addition for SUBDIRS and EXTRA_DIST.
Is the build order important for po/intl vs code?
Fabio
next prev parent reply other threads:[~2011-06-01 4:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 19:37 [Cluster-devel] [PATCH] Add i18n infra-structure Carlos Maiolino
2011-06-01 4:28 ` Fabio M. Di Nitto [this message]
2011-06-01 8:58 ` Steven Whitehouse
2011-06-01 13:35 ` Carlos Maiolino
-- strict thread matches above, loose matches on Subject: below --
2011-05-31 18:00 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE5BFDA.2010404@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).