cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] rgmanager: Fix bad passing of SFL_FAILURE up - RHEL5
Date: Fri, 24 Jun 2011 14:28:17 +0200	[thread overview]
Message-ID: <4E0482E1.9010700@redhat.com> (raw)
In-Reply-To: <1308851160-18455-1-git-send-email-lhh@redhat.com>

ACK

On 6/23/2011 7:46 PM, Lon Hohberger wrote:
> We were handling failures at the 'highest' independent subtree
> level instead of lowest; this patch fixes that.
> 
> Resolves: rhbz#711521
> 
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
>  rgmanager/src/daemons/restree.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/rgmanager/src/daemons/restree.c b/rgmanager/src/daemons/restree.c
> index 697c7b1..4e5f3bc 100644
> --- a/rgmanager/src/daemons/restree.c
> +++ b/rgmanager/src/daemons/restree.c
> @@ -1603,7 +1603,7 @@ _res_op_internal(resource_node_t __attribute__ ((unused)) **tree,
>  		  and all our children as failed and return a flag stating
>  		  that this section is recoverable apart from siblings in
>  		  the resource tree. */
> -		if (op == RS_STATUS && (rv & (SFL_FAILURE|SFL_RECOVERABLE)) &&
> +		if (op == RS_STATUS && (rv & SFL_FAILURE) &&
>  		    (node->rn_flags & RF_INDEPENDENT)) {
>  
>  			rte = restart_threshold_exceeded(node->rn_restart_counter);



      reply	other threads:[~2011-06-24 12:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-23 17:46 [Cluster-devel] [PATCH] rgmanager: Fix bad passing of SFL_FAILURE up - RHEL5 Lon Hohberger
2011-06-24 12:28 ` Fabio M. Di Nitto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0482E1.9010700@redhat.com \
    --to=fdinitto@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).