From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
Date: Thu, 11 Aug 2011 05:57:55 +0200 [thread overview]
Message-ID: <4E435343.2040504@redhat.com> (raw)
In-Reply-To: <399555775.2257585.1313029724659.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
On 08/11/2011 04:28 AM, Chris Feist wrote:
>
>>> 12 files changed, 53 insertions(+), 11 deletions(-)
>>> mode change 100644 => 100755 rgmanager/src/resources/apache.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/ip.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
>>> mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
>>> mode change 100644 => 100755
>>> rgmanager/src/resources/utils/httpd-parse-config.pl
>>
>> Modes didn't need to be changed.
>
> Modes need to be changed to pass ocf_tester (it's one of the tests), should we just skip this?
>
It makes sense to be able to test within the source tree too. At the
time those files were set 0644, we had no test and no use case to keep
them executable within the source. Now we do. ACK from me.
The agents are installed 0755 in /usr/share/cluster by Makefile targets.
Can you please cross check if also utils/httpd-parse-config.pl is 0755
once installed? If not we need to fix that in utils/Makefile.am.
Fabio
prev parent reply other threads:[~2011-08-11 3:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 18:13 [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager Chris Feist
2011-08-11 0:44 ` Lon Hohberger
2011-08-11 2:28 ` Chris Feist
2011-08-11 2:56 ` Chris Feist
2011-08-12 1:18 ` Lon Hohberger
2011-08-11 3:57 ` Fabio M. Di Nitto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E435343.2040504@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).