* [Cluster-devel] dlm: master - dlm: clear out old stuff and build system
[not found] <20110930215717.E852C12015A@lists.fedorahosted.org>
@ 2011-10-01 5:32 ` Fabio M. Di Nitto
2011-10-03 18:23 ` David Teigland
0 siblings, 1 reply; 3+ messages in thread
From: Fabio M. Di Nitto @ 2011-10-01 5:32 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi David,
you have gone a bit too heavy handed on this one :)
On 09/30/2011 11:57 PM, David Teigland wrote:
dlm: clear out old stuff and build system
Signed-off-by: David Teigland <teigland@redhat.com>
---
dlm/libdlm/libdlm.pc.in | 11 -
dlm/libdlm/libdlm_lt.pc.in | 11 -
dropping the .pc file is going to break dlm users.
pc files are used by different build systems (not just
autotools/autoconf) to detect libdlm and link against it correctly.
Similar to what you use for libxml2 in your new build system, they
provide pkg-config information.
doc/COPYING.applications | 339 --------
doc/COPYING.libraries | 510 ------------
doc/COPYRIGHT | 42 -
doc/README.licence | 33 -
You need those files to keep the project under the proper licence and
copyright to the right people.
Even if they are not in this exact form, you will need COPYING.app|libs
and a COPYRIGHT file. Alternatively you need to add those info to each
file in the project.
Fabio
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] dlm: master - dlm: clear out old stuff and build system
2011-10-01 5:32 ` [Cluster-devel] dlm: master - dlm: clear out old stuff and build system Fabio M. Di Nitto
@ 2011-10-03 18:23 ` David Teigland
2011-10-03 20:45 ` Fabio M. Di Nitto
0 siblings, 1 reply; 3+ messages in thread
From: David Teigland @ 2011-10-03 18:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
> dlm/libdlm/libdlm.pc.in | 11 -
> dlm/libdlm/libdlm_lt.pc.in | 11 -
>
> dropping the .pc file is going to break dlm users.
>
> pc files are used by different build systems (not just
> autotools/autoconf) to detect libdlm and link against it correctly.
>
> Similar to what you use for libxml2 in your new build system, they
> provide pkg-config information.
ok, I've pushed this out, including this which I suspect is not quite
correct:
DESTDIR=
PREFIX=/usr
LIBDIR=/usr/lib64
HDRDIR=/usr/include
MANDIR=/usr/share/man
PKGDIR=/usr/lib64/pkgconfig
UDEVDIR=/etc/udev/rules.d
Should all references to /usr be $(PREFIX) instead?
> Even if they are not in this exact form, you will need COPYING.app|libs
> and a COPYRIGHT file. Alternatively you need to add those info to each
> file in the project.
yep, getting there
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] dlm: master - dlm: clear out old stuff and build system
2011-10-03 18:23 ` David Teigland
@ 2011-10-03 20:45 ` Fabio M. Di Nitto
0 siblings, 0 replies; 3+ messages in thread
From: Fabio M. Di Nitto @ 2011-10-03 20:45 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 10/03/2011 08:23 PM, David Teigland wrote:
>> dlm/libdlm/libdlm.pc.in | 11 -
>> dlm/libdlm/libdlm_lt.pc.in | 11 -
>>
>> dropping the .pc file is going to break dlm users.
>>
>> pc files are used by different build systems (not just
>> autotools/autoconf) to detect libdlm and link against it correctly.
>>
>> Similar to what you use for libxml2 in your new build system, they
>> provide pkg-config information.
>
> ok, I've pushed this out, including this which I suspect is not quite
> correct:
>
> DESTDIR=
> PREFIX=/usr
> LIBDIR=/usr/lib64
> HDRDIR=/usr/include
> MANDIR=/usr/share/man
> PKGDIR=/usr/lib64/pkgconfig
> UDEVDIR=/etc/udev/rules.d
>
> Should all references to /usr be $(PREFIX) instead?
yes, that's correct. /usr -> $(PREFIX)
There is also a more generic problem that lib64 is not always correct
and depends on architecture, distribution and in some extreme cases
multiarch implementation (something somewhat new that's being pushed
hard in Debian)
Most ./configure would detect it correctly, but in your case, set a
default that allows override (same way as you handle PREFIX).
One minor nit-pick, UDEVDIR upstream has changed to /lib/udev/rules.d
(/lib is hardcoded and doesn't change to /lib64 like it does for libraries).
We never changed STABLE31 since /etc/ still works, but by the time the
new dlm will be available, we should move it in the right location.
Fabio
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-03 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110930215717.E852C12015A@lists.fedorahosted.org>
2011-10-01 5:32 ` [Cluster-devel] dlm: master - dlm: clear out old stuff and build system Fabio M. Di Nitto
2011-10-03 18:23 ` David Teigland
2011-10-03 20:45 ` Fabio M. Di Nitto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).