From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lon Hohberger <lhh@redhat.com>
Date: Tue, 29 Nov 2011 12:59:05 -0500
Subject: [Cluster-devel] [PATCH 32/41] qdiskd: clean code around case
In-Reply-To: <f0e7c8aa6b3c600e5c300d9b51ff67260699cf4e.1322043045.git.fdinitto@redhat.com>
References: <1322043360-17037-1-git-send-email-fdinitto@redhat.com>
	<f0e7c8aa6b3c600e5c300d9b51ff67260699cf4e.1322043045.git.fdinitto@redhat.com>
Message-ID: <4ED51D69.3040506@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 11/23/2011 05:15 AM, Fabio M. Di Nitto wrote:
> Spotted by Coverity Scan
>
> Signed-off-by: Fabio M. Di Nitto<fdinitto@redhat.com>
> ---
> :100644 100644 c4db713... 51d9a39... M	cman/qdisk/main.c
>   cman/qdisk/main.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/cman/qdisk/main.c b/cman/qdisk/main.c
> index c4db713..51d9a39 100644
> --- a/cman/qdisk/main.c
> +++ b/cman/qdisk/main.c
> @@ -146,9 +146,11 @@ check_self(qd_ctx *ctx, status_block_t *sb)
>   	case S_EVICT:
>   		/* Someone told us to die. */
>   		reboot(RB_AUTOBOOT);
> +		break;

This fallthrough to 'default' was deliberate.

>   	default:
>   		logt_print(LOG_EMERG, "Unhandled state: %d\n", sb->ps_state);
>   		raise(SIGSTOP);
> +		break;
>   	}
>   }
>