From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lon Hohberger <lhh@redhat.com>
Date: Tue, 29 Nov 2011 13:04:00 -0500
Subject: [Cluster-devel] [PATCH 38/41] qdiskd: fix possible resource
 leak in	scandisk
In-Reply-To: <11321ea42382105acf810696a29c70d778082907.1322043046.git.fdinitto@redhat.com>
References: <1322043360-17037-1-git-send-email-fdinitto@redhat.com>
	<11321ea42382105acf810696a29c70d778082907.1322043046.git.fdinitto@redhat.com>
Message-ID: <4ED51E90.9060504@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 11/23/2011 05:15 AM, Fabio M. Di Nitto wrote:
> Spotted by Coverity Scan
>

> -	while (fgets(line, sizeof(line), fp)
> -	       != NULL) {
> +
> +	while (fgets(line, sizeof(line) - 1, fp) != NULL) {

fgets takes at most size-1, this isn't needed

-- Lon