From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Wed, 14 Dec 2011 17:14:21 +0000 Subject: [Cluster-devel] [PATCH 1/2] libgfs2: Expand out calls to die() In-Reply-To: <1323880882.2860.24.camel@menhir> References: <1323879637-28987-1-git-send-email-anprice@redhat.com> <1323880882.2860.24.camel@menhir> Message-ID: <4EE8D96D.60500@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 14/12/11 16:41, Steven Whitehouse wrote: > Hi, > > Those look like a good start, but we also need to figure out how to push > the error handling back into the apps too, Yes, I made a tentative start on this a while ago. Each libgfs2 function which calls exit() will need all of its callers (and their callers, and their...) updating so it's going to take a fair deal more work. If we're agreed on the convention of setting errno and returning non-zero (or non-valid values) to flag errors, then the way forward is reasonably clear. Andy