From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio M. Di Nitto Date: Tue, 06 Mar 2012 05:08:54 +0100 Subject: [Cluster-devel] [Patch] GFS2: Add gfs2_lockgather script and man page In-Reply-To: <1330972478.2699.112.camel@menhir> References: <4F55059F.4070809@redhat.com> <1330972478.2699.112.camel@menhir> Message-ID: <4F558DD6.5060605@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 03/05/2012 07:34 PM, Steven Whitehouse wrote: > Hi, > > On Mon, 2012-03-05 at 19:27 +0100, Fabio M. Di Nitto wrote: >> On 03/05/2012 06:51 PM, Adam Drew wrote: >>> This is a backport of the gfs2_lockgather script and manpage from gfs2_utils upstream. >> >> I have to NACK this backport for now. >> >> I already explain to Adam what needs changing. >> >> Fabio >> > > What is the issue? Forgot to mention in the previous email: since this is a long time (tar/ssh/scp..) running script, it needs to handle trap of signals and locking differently or if a user hits ctrl+c or the script is killed for whatever reason, it doesn't clean after itself. Leaking disk space and leaving the lock file around that would block the next run. I didn't check all the paths it uses, but an update to selinux policies might be necessary too. Fabio