* [Cluster-devel] [PATCH] fence_scsi_test: increment error count when reservation fails
@ 2012-04-09 14:34 Ryan O'Hara
2012-04-09 17:11 ` Lon Hohberger
0 siblings, 1 reply; 2+ messages in thread
From: Ryan O'Hara @ 2012-04-09 14:34 UTC (permalink / raw)
To: cluster-devel.redhat.com
If the do_action_on subroutine fails to create a reservation, the
error count should be incremented not set to zero.
Resolves: rhbz#809481
Signed-off-by: Ryan O'Hara <rohara@redhat.com>
---
fence/agents/scsi/fence_scsi_test.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fence/agents/scsi/fence_scsi_test.pl
b/fence/agents/scsi/fence_scsi_test.pl
index 5c2302c..c012a12 100755
--- a/fence/agents/scsi/fence_scsi_test.pl
+++ b/fence/agents/scsi/fence_scsi_test.pl
@@ -44,7 +44,7 @@ sub do_action_on (\@$$)
if (scalar (get_keys_reserve ($dev)) == 0) {
if (do_reserve ($dev, $node_key) != 0) {
- $err = 0;
+ $err++;
}
}
-- 1.7.1
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Attached Message Part
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20120409/aebee3f2/attachment.ksh>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [PATCH] fence_scsi_test: increment error count when reservation fails
2012-04-09 14:34 [Cluster-devel] [PATCH] fence_scsi_test: increment error count when reservation fails Ryan O'Hara
@ 2012-04-09 17:11 ` Lon Hohberger
0 siblings, 0 replies; 2+ messages in thread
From: Lon Hohberger @ 2012-04-09 17:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 04/09/2012 10:34 AM, Ryan O'Hara wrote:
> If the do_action_on subroutine fails to create a reservation, the
> error count should be incremented not set to zero.
>
> Resolves: rhbz#809481
ACK
-- Lon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-09 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-09 14:34 [Cluster-devel] [PATCH] fence_scsi_test: increment error count when reservation fails Ryan O'Hara
2012-04-09 17:11 ` Lon Hohberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).