* [Cluster-devel] [PATCH 3/5] rgmanager: Don't immediately stop services that have started sucessfully
@ 2012-06-28 19:57 Ryan McCabe
2012-07-04 11:06 ` Fabio M. Di Nitto
0 siblings, 1 reply; 2+ messages in thread
From: Ryan McCabe @ 2012-06-28 19:57 UTC (permalink / raw)
To: cluster-devel.redhat.com
This patch fixes a bug that caused services to be started, then
immediately stopped during recovery. This occurred when a service
had its recovery policy set to relocate and was in a restricted
failover domain. If starting the service failed on other nodes in the
failover domain, the service would be restarted on the original node,
then immediately stopped, even if it had started successfully. This
patch causes rgmanager to leave the service running if it restarted
successfully.
Resolves: rhbz#789366
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
---
rgmanager/src/daemons/rg_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
index a8b1e36..4357d21 100644
--- a/rgmanager/src/daemons/rg_state.c
+++ b/rgmanager/src/daemons/rg_state.c
@@ -2061,7 +2061,7 @@ exhausted:
svcName);
if (svc_start(svcName, RG_START_RECOVER) == 0) {
*new_owner = me;
- return RG_EFAIL;
+ return 0;
}
}
--
1.7.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [PATCH 3/5] rgmanager: Don't immediately stop services that have started sucessfully
2012-06-28 19:57 [Cluster-devel] [PATCH 3/5] rgmanager: Don't immediately stop services that have started sucessfully Ryan McCabe
@ 2012-07-04 11:06 ` Fabio M. Di Nitto
0 siblings, 0 replies; 2+ messages in thread
From: Fabio M. Di Nitto @ 2012-07-04 11:06 UTC (permalink / raw)
To: cluster-devel.redhat.com
ACK
On 6/28/2012 9:57 PM, Ryan McCabe wrote:
> This patch fixes a bug that caused services to be started, then
> immediately stopped during recovery. This occurred when a service
> had its recovery policy set to relocate and was in a restricted
> failover domain. If starting the service failed on other nodes in the
> failover domain, the service would be restarted on the original node,
> then immediately stopped, even if it had started successfully. This
> patch causes rgmanager to leave the service running if it restarted
> successfully.
>
> Resolves: rhbz#789366
>
> Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
> ---
> rgmanager/src/daemons/rg_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
> index a8b1e36..4357d21 100644
> --- a/rgmanager/src/daemons/rg_state.c
> +++ b/rgmanager/src/daemons/rg_state.c
> @@ -2061,7 +2061,7 @@ exhausted:
> svcName);
> if (svc_start(svcName, RG_START_RECOVER) == 0) {
> *new_owner = me;
> - return RG_EFAIL;
> + return 0;
> }
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-04 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-28 19:57 [Cluster-devel] [PATCH 3/5] rgmanager: Don't immediately stop services that have started sucessfully Ryan McCabe
2012-07-04 11:06 ` Fabio M. Di Nitto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).